[gnome-software/gnome-3-26] screenshot image: Fix a memory leak when loading multiple times



commit 6303589ba3974f85e85bf8bf478ee2cb6de8a1d6
Author: Kalev Lember <klember redhat com>
Date:   Mon Jan 15 23:59:12 2018 +0100

    screenshot image: Fix a memory leak when loading multiple times

 src/gs-screenshot-image.c | 2 ++
 1 file changed, 2 insertions(+)
---
diff --git a/src/gs-screenshot-image.c b/src/gs-screenshot-image.c
index 744b495d..7f70c556 100644
--- a/src/gs-screenshot-image.c
+++ b/src/gs-screenshot-image.c
@@ -465,6 +465,7 @@ gs_screenshot_image_load_async (GsScreenshotImage *ssimg,
        /* check if the URL points to a local file */
        url = as_image_get_url (im);
        if (g_str_has_prefix (url, "file://")) {
+               g_free (ssimg->filename);
                ssimg->filename = g_strdup (url + 7);
                if (g_file_test (ssimg->filename, G_FILE_TEST_EXISTS)) {
                        as_screenshot_show_image (ssimg);
@@ -479,6 +480,7 @@ gs_screenshot_image_load_async (GsScreenshotImage *ssimg,
                sizedir = g_strdup_printf ("%ux%u", ssimg->width * ssimg->scale, ssimg->height * 
ssimg->scale);
        }
        cache_kind = g_build_filename ("screenshots", sizedir, NULL);
+       g_free (ssimg->filename);
        ssimg->filename = gs_utils_get_cache_filename (cache_kind,
                                                       basename,
                                                       GS_UTILS_CACHE_FLAG_NONE,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]