[gnome-software] trivial: sources dialog: Minor tweak

[Kalev Lember <klember src gnome org>]

commit c95d6a5d05131fa4ffbe784ee14d7f9019d0173d
Author: Kalev Lember <klember redhat com>
Date:   Thu Feb 8 08:49:09 2018 +0100

    trivial: sources dialog: Minor tweak

 src/gs-sources-dialog.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
---
diff --git a/src/gs-sources-dialog.c b/src/gs-sources-dialog.c
index b875dec0..7ea6aa07 100644
--- a/src/gs-sources-dialog.c
+++ b/src/gs-sources-dialog.c
@@ -195,15 +195,13 @@ source_removed_cb (GObject *source,
 }
 
 static void
-gs_sources_dialog_install_remove_proprietary_sources (GsSourcesDialog *dialog)
+gs_sources_dialog_install_proprietary_sources (GsSourcesDialog *dialog, gboolean install)
 {
-       gboolean switch_active = gs_sources_dialog_row_get_switch_active (GS_SOURCES_DIALOG_ROW 
(dialog->row_proprietary));
-
        for (guint i = 0; i < gs_app_list_length (dialog->nonfree_source_list); i++) {
                GsApp *app = gs_app_list_index (dialog->nonfree_source_list, i);
 
                /* add or remove the source */
-               if (switch_active) {
+               if (install) {
                        if (gs_app_get_state (app) == AS_APP_STATE_AVAILABLE) {
                                g_autoptr(GsPluginJob) plugin_job = NULL;
                                plugin_job = gs_plugin_job_newv (GS_PLUGIN_ACTION_INSTALL,
@@ -236,7 +234,10 @@ gs_sources_dialog_switch_active_cb (GsSourcesDialogRow *row,
                                    GParamSpec *pspec,
                                    GsSourcesDialog *dialog)
 {
-       gs_sources_dialog_install_remove_proprietary_sources (dialog);
+       gboolean active;
+
+       active = gs_sources_dialog_row_get_switch_active (GS_SOURCES_DIALOG_ROW (dialog->row_proprietary));
+       gs_sources_dialog_install_proprietary_sources (dialog, active);
        g_settings_set_boolean (dialog->settings, "show-nonfree-prompt", FALSE);
 }