[gimp] app: don't check stack_trace_mode anymore in gimp_get_stack_trace().



commit 753f4cf4a3ec2cfdfbd92c9521187223c6667e09
Author: Jehan <jehan girinstud io>
Date:   Wed Feb 7 00:45:40 2018 +0100

    app: don't check stack_trace_mode anymore in gimp_get_stack_trace().
    
    These are now parallel concepts. The stack_trace_mode is for the CLI
    option and the check happens on another level already.

 app/errors.c |   17 +++++------------
 1 files changed, 5 insertions(+), 12 deletions(-)
---
diff --git a/app/errors.c b/app/errors.c
index 24ce81a..8315365 100644
--- a/app/errors.c
+++ b/app/errors.c
@@ -395,23 +395,16 @@ static gchar *
 gimp_get_stack_trace (void)
 {
   gchar   *trace  = NULL;
-#ifndef G_OS_WIN32
-  gchar   *args[7] = { "gdb", "-batch", "-ex", "backtrace full",
-                       full_prog_name, NULL, NULL };
-  gchar   *gdb_stdout;
-  gchar    pid[16];
-#endif
-
-  /* Though we should theoretically ask with GIMP_STACK_TRACE_QUERY, we
-   * just assume yes right now. TODO: improve this!
-   */
-  if (stack_trace_mode == GIMP_STACK_TRACE_NEVER)
-    return NULL;
 
   /* This works only on UNIX systems. On Windows, we'll have to find
    * another method, probably with DrMingW.
    */
 #ifndef G_OS_WIN32
+  gchar *args[7] = { "gdb", "-batch", "-ex", "backtrace full",
+                     full_prog_name, NULL, NULL };
+  gchar *gdb_stdout;
+  gchar  pid[16];
+
   g_snprintf (pid, 16, "%u", (guint) getpid ());
   args[5] = pid;
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]