[gnome-photos/wip/rishi/collection: 2/52] export-dialog: Set the bottom margins through the XML definition



commit 17787b77084d108c548e9b80de3c1f90ebe2b7df
Author: Debarshi Ray <debarshir gnome org>
Date:   Tue Feb 6 14:16:08 2018 +0100

    export-dialog: Set the bottom margins through the XML definition
    
    There doesn't seem to be any reason to set them using C code. They are
    set during construction, barring the still-born code path for
    collections, and never removed during the lifetime of the dialog.
    
    Fallout 3ce13b4675b8098efad5c9af31536c6cac712a7b

 src/photos-export-dialog.c  | 3 ---
 src/photos-export-dialog.ui | 2 ++
 2 files changed, 2 insertions(+), 3 deletions(-)
---
diff --git a/src/photos-export-dialog.c b/src/photos-export-dialog.c
index 46e8a5ee..4519f3dd 100644
--- a/src/photos-export-dialog.c
+++ b/src/photos-export-dialog.c
@@ -76,9 +76,6 @@ photos_export_dialog_show_size_options (PhotosExportDialog *self, gboolean size_
   const gchar *class_name;
   const gchar *invert_class_name;
 
-  gtk_widget_set_margin_bottom (self->dir_entry, 6);
-  gtk_widget_set_margin_bottom (self->folder_name_label, 6);
-
   class_name = progress ? "photos-fade-in" : "photos-fade-out";
   invert_class_name = !progress ? "photos-fade-in" : "photos-fade-out";
 
diff --git a/src/photos-export-dialog.ui b/src/photos-export-dialog.ui
index 802c32f2..983367f3 100644
--- a/src/photos-export-dialog.ui
+++ b/src/photos-export-dialog.ui
@@ -36,6 +36,7 @@
               <object class="GtkLabel" id="folder_name_label">
                 <property name="halign">end</property>
                 <property name="label" translatable="yes">_Folder Name</property>
+                <property name="margin_bottom">6</property>
                 <property name="mnemonic_widget">dir_entry</property>
                 <property name="use_underline">1</property>
                 <style>
@@ -50,6 +51,7 @@
             <child>
               <object class="GtkEntry" id="dir_entry">
                 <property name="activates_default">1</property>
+                <property name="margin_bottom">6</property>
                 <property name="width_chars">30</property>
               </object>
               <packing>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]