[evolution-data-server] Correct return value of e_soup_session_get_authentication_requires_credentials()



commit 89e46636690834978b3be7b6540373baa33076c0
Author: Milan Crha <mcrha redhat com>
Date:   Fri Feb 2 15:20:04 2018 +0100

    Correct return value of e_soup_session_get_authentication_requires_credentials()

 .../backends/webdav/e-book-backend-webdav.c        |    2 +-
 .../backends/caldav/e-cal-backend-caldav.c         |    2 +-
 src/libedataserver/e-soup-session.c                |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/src/addressbook/backends/webdav/e-book-backend-webdav.c 
b/src/addressbook/backends/webdav/e-book-backend-webdav.c
index cc98b9b..d52c715 100644
--- a/src/addressbook/backends/webdav/e-book-backend-webdav.c
+++ b/src/addressbook/backends/webdav/e-book-backend-webdav.c
@@ -214,7 +214,7 @@ ebb_webdav_connect_sync (EBookMetaBackend *meta_backend,
                gboolean is_ssl_error;
 
                credentials_empty = (!credentials || !e_named_parameters_count (credentials)) &&
-                       !e_soup_session_get_authentication_requires_credentials (E_SOUP_SESSION 
(bbdav->priv->webdav));
+                       e_soup_session_get_authentication_requires_credentials (E_SOUP_SESSION 
(bbdav->priv->webdav));
                is_ssl_error = g_error_matches (local_error, SOUP_HTTP_ERROR, SOUP_STATUS_SSL_FAILED);
 
                *out_auth_result = E_SOURCE_AUTHENTICATION_ERROR;
diff --git a/src/calendar/backends/caldav/e-cal-backend-caldav.c 
b/src/calendar/backends/caldav/e-cal-backend-caldav.c
index 4551dea..c028c5a 100644
--- a/src/calendar/backends/caldav/e-cal-backend-caldav.c
+++ b/src/calendar/backends/caldav/e-cal-backend-caldav.c
@@ -175,7 +175,7 @@ ecb_caldav_connect_sync (ECalMetaBackend *meta_backend,
                gboolean is_ssl_error;
 
                credentials_empty = (!credentials || !e_named_parameters_count (credentials)) &&
-                       !e_soup_session_get_authentication_requires_credentials (E_SOUP_SESSION 
(cbdav->priv->webdav));
+                       e_soup_session_get_authentication_requires_credentials (E_SOUP_SESSION 
(cbdav->priv->webdav));
                is_ssl_error = g_error_matches (local_error, SOUP_HTTP_ERROR, SOUP_STATUS_SSL_FAILED);
 
                *out_auth_result = E_SOURCE_AUTHENTICATION_ERROR;
diff --git a/src/libedataserver/e-soup-session.c b/src/libedataserver/e-soup-session.c
index 5f1721a..c0f77f7 100644
--- a/src/libedataserver/e-soup-session.c
+++ b/src/libedataserver/e-soup-session.c
@@ -621,7 +621,7 @@ e_soup_session_get_authentication_requires_credentials (ESoupSession *session)
 {
        g_return_val_if_fail (E_IS_SOUP_SESSION (session), FALSE);
 
-       return session->priv->using_bearer_auth != NULL;
+       return !session->priv->using_bearer_auth;
 }
 
 /**


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]