[librsvg] Remove all calls to rsvg_cleanup() since it's a no-op now



commit 9e0c1f6871e015f094aafd93e58f35ba0379bfa2
Author: Federico Mena Quintero <federico gnome org>
Date:   Thu Dec 27 19:07:22 2018 -0600

    Remove all calls to rsvg_cleanup() since it's a no-op now
    
    I'm not sure if we should call xmlCleanupParser() in the tests
    instead.  In theory, Valgrind should not show reachable memory from
    libxml2 as leaks.

 rsvg-convert.c          | 2 --
 rsvg-view.c             | 2 --
 tests/api.c             | 2 +-
 tests/crash.c           | 2 --
 tests/dimensions.c      | 2 --
 tests/infinite-loop.c   | 2 --
 tests/loading.c         | 2 --
 tests/render-crash.c    | 2 --
 tests/rsvg-test.c       | 2 --
 tests/styles.c          | 2 --
 tools/rsvg-dimensions.c | 2 --
 tools/rsvg-tools-main.c | 1 -
 12 files changed, 1 insertion(+), 22 deletions(-)
---
diff --git a/rsvg-convert.c b/rsvg-convert.c
index 77d0fe92..3f08adfc 100644
--- a/rsvg-convert.c
+++ b/rsvg-convert.c
@@ -508,7 +508,5 @@ main (int argc, char **argv)
 
     g_strfreev (args);
 
-    rsvg_cleanup ();
-
     return 0;
 }
diff --git a/rsvg-view.c b/rsvg-view.c
index 10f0e094..a56c840b 100644
--- a/rsvg-view.c
+++ b/rsvg-view.c
@@ -758,7 +758,5 @@ main (int argc, char **argv)
     g_free (info.base_uri);
     g_object_unref (info.handle);
 
-    rsvg_cleanup ();
-
     return retval;
 }
diff --git a/tests/api.c b/tests/api.c
index 73310433..5b535e9b 100644
--- a/tests/api.c
+++ b/tests/api.c
@@ -166,7 +166,7 @@ noops (void)
     /* Just to test that these functions are present in the binary, I guess */
     rsvg_init ();
     rsvg_term ();
-    g_assert (rsvg_cleanup != NULL); /* shouldn't call this one! */
+    rsvg_cleanup ();
 }
 
 static void
diff --git a/tests/crash.c b/tests/crash.c
index 638b8b3a..5230af9a 100644
--- a/tests/crash.c
+++ b/tests/crash.c
@@ -50,7 +50,5 @@ main (int argc, char *argv[])
 
     result = g_test_run ();
 
-    rsvg_cleanup ();
-
     return result;
 }
diff --git a/tests/dimensions.c b/tests/dimensions.c
index 9f99a09d..df837815 100644
--- a/tests/dimensions.c
+++ b/tests/dimensions.c
@@ -158,7 +158,5 @@ main (int argc, char *argv[])
 
     result = g_test_run ();
 
-    rsvg_cleanup ();
-
     return result;
 }
diff --git a/tests/infinite-loop.c b/tests/infinite-loop.c
index 978c97dc..9eb7f394 100644
--- a/tests/infinite-loop.c
+++ b/tests/infinite-loop.c
@@ -64,7 +64,5 @@ main (int argc, char *argv[])
 
     result = g_test_run ();
 
-    rsvg_cleanup ();
-
     return result;
 }
diff --git a/tests/loading.c b/tests/loading.c
index 1cf79d2f..22e0398e 100644
--- a/tests/loading.c
+++ b/tests/loading.c
@@ -77,7 +77,5 @@ main (int argc, char **argv)
 
     result = g_test_run ();
 
-    rsvg_cleanup ();
-
     return result;
 }
diff --git a/tests/render-crash.c b/tests/render-crash.c
index 105c35de..91f99804 100644
--- a/tests/render-crash.c
+++ b/tests/render-crash.c
@@ -73,7 +73,5 @@ main (int argc, char *argv[])
 
     result = g_test_run ();
 
-    rsvg_cleanup ();
-
     return result;
 }
diff --git a/tests/rsvg-test.c b/tests/rsvg-test.c
index 0e4323ac..05a7c6b9 100644
--- a/tests/rsvg-test.c
+++ b/tests/rsvg-test.c
@@ -441,8 +441,6 @@ main (int argc, char **argv)
 
     result = g_test_run ();
 
-    rsvg_cleanup ();
-
     return result;
 }
 
diff --git a/tests/styles.c b/tests/styles.c
index 147cd9f5..4a4966a8 100644
--- a/tests/styles.c
+++ b/tests/styles.c
@@ -120,7 +120,5 @@ main (int argc, char *argv[])
 
     result = g_test_run ();
 
-    rsvg_cleanup ();
-
     return result;
 }
diff --git a/tools/rsvg-dimensions.c b/tools/rsvg-dimensions.c
index 9816e67c..92d58fd3 100644
--- a/tools/rsvg-dimensions.c
+++ b/tools/rsvg-dimensions.c
@@ -145,7 +145,5 @@ bail:
     if (error)
         g_error_free (error), error = NULL;
 
-    rsvg_cleanup ();
-
     return exit_code;
 }
diff --git a/tools/rsvg-tools-main.c b/tools/rsvg-tools-main.c
index d9919682..11a8e12c 100644
--- a/tools/rsvg-tools-main.c
+++ b/tools/rsvg-tools-main.c
@@ -176,7 +176,6 @@ rsvg_tools_main (int *argc, char ***argv)
     }
 
     g_strfreev (args);
-    rsvg_cleanup ();
 
     return 0;
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]