[gjs: 4/15] fundamental: Remove obsolete comments



commit e75d61d59abbf3e614dc375441b05e7e3dd4cfdd
Author: Philip Chimento <philip chimento gmail com>
Date:   Fri Dec 7 18:49:50 2018 -0800

    fundamental: Remove obsolete comments
    
    JSCLASS_CONSTRUCT_PROTOTYPE does not exist any longer, so whatever it
    was used for originally, no longer applies anyway.

 gi/fundamental.cpp | 13 -------------
 1 file changed, 13 deletions(-)
---
diff --git a/gi/fundamental.cpp b/gi/fundamental.cpp
index cf1071fa..5cecadc7 100644
--- a/gi/fundamental.cpp
+++ b/gi/fundamental.cpp
@@ -401,14 +401,6 @@ fundamental_invoke_constructor(FundamentalInstance        *priv,
     return gjs_invoke_constructor_from_c(context, constructor, obj, args, rvalue);
 }
 
-/* If we set JSCLASS_CONSTRUCT_PROTOTYPE flag, then this is called on
- * the prototype in addition to on each instance. When called on the
- * prototype, "obj" is the prototype, and "retval" is the prototype
- * also, but can be replaced with another object to use instead as the
- * prototype. If we don't set JSCLASS_CONSTRUCT_PROTOTYPE we can
- * identify the prototype as an object of our class with NULL private
- * data.
- */
 GJS_NATIVE_CONSTRUCTOR_DECLARE(fundamental_instance)
 {
     GJS_NATIVE_CONSTRUCTOR_VARIABLES(fundamental_instance)
@@ -524,11 +516,6 @@ fundamental_trace(JSTracer *tracer,
 /* The bizarre thing about this vtable is that it applies to both
  * instances of the object, and to the prototype that instances of the
  * class have.
- *
- * Also, there's a constructor field in here, but as far as I can
- * tell, it would only be used if no constructor were provided to
- * JS_InitClass. The constructor from JS_InitClass is not applied to
- * the prototype unless JSCLASS_CONSTRUCT_PROTOTYPE is in flags.
  */
 static const struct JSClassOps gjs_fundamental_class_ops = {
     nullptr,  // addProperty


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]