[gnome-applets] charpick: remove button press hack



commit 5aba92f62ce6c77ad902fedda1b0f1bbc437ddb2
Author: Alberts Muktupāvels <alberts muktupavels gmail com>
Date:   Sat Dec 22 17:48:41 2018 +0200

    charpick: remove button press hack
    
    Hack was added in 97fc96e23f0adb26354a84591f11a083ff056f14 commit,
    unfortunately it does not have any extra information why it was
    needed.
    
    It does not seem to be true with GTK+ 3. Remove hack and let GTK+
    do its job.

 charpick/src/charpick.c | 23 -----------------------
 1 file changed, 23 deletions(-)
---
diff --git a/charpick/src/charpick.c b/charpick/src/charpick.c
index 6e790dbfe..6412861a1 100644
--- a/charpick/src/charpick.c
+++ b/charpick/src/charpick.c
@@ -180,23 +180,6 @@ toggle_button_toggled_cb(GtkToggleButton *button, gpointer data)
   return TRUE;
 }
 
-/* This is a hack around the fact that gtk+ doesn't
- * propogate button presses on button2/3.
- */
-static gboolean
-button_press_hack (GtkWidget      *widget,
-                  GdkEventButton *event,
-                  GtkWidget      *applet)
-{
-    if (event->button == 3 || event->button == 2) {
-       gtk_propagate_event (applet, (GdkEvent *) event);
-
-       return TRUE;
-    }
-
-    return FALSE;
-}
-
 static gint
 key_press_event(GtkWidget *widget, GdkEventKey *event, gpointer data)
 {
@@ -426,10 +409,6 @@ build_table(charpick_data *p_curr_data)
     g_signal_connect (G_OBJECT (button), "clicked",
                               G_CALLBACK (chooser_button_clicked),
                              p_curr_data);
-    g_signal_connect (G_OBJECT (button), "button_press_event",
-                               G_CALLBACK (button_press_hack),
-                              p_curr_data->applet);
-  
   }
   
   charlist = g_strdup (p_curr_data->charlist);
@@ -474,8 +453,6 @@ build_table(charpick_data *p_curr_data)
     g_signal_connect (G_OBJECT (toggle_button[i]), "toggled",
                      G_CALLBACK (toggle_button_toggled_cb),
                         p_curr_data);
-    g_signal_connect (G_OBJECT (toggle_button[i]), "button_press_event", 
-                      G_CALLBACK (button_press_hack), p_curr_data->applet);
   }
   
   if (p_curr_data->panel_vertical) {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]