[gnome-music/wip/jfelder/songsview-favourite-click] starhandlerwidget: Do not activate in selection mode



commit 774abaa987e3bd8269cb793cbcc24fe8de9832b3
Author: Jean Felder <jfelder src gnome org>
Date:   Wed Dec 19 16:22:12 2018 +0100

    starhandlerwidget: Do not activate in selection mode
    
    When a view is in selection mode, clicking on a star should have no
    effect.

 gnomemusic/views/songsview.py           | 2 --
 gnomemusic/widgets/starhandlerwidget.py | 3 +++
 2 files changed, 3 insertions(+), 2 deletions(-)
---
diff --git a/gnomemusic/views/songsview.py b/gnomemusic/views/songsview.py
index 553469ad..ff240cbb 100644
--- a/gnomemusic/views/songsview.py
+++ b/gnomemusic/views/songsview.py
@@ -219,8 +219,6 @@ class SongsView(BaseView):
                 and not self.props.selection_mode):
             self._on_selection_mode_request()
 
-        # FIXME: In selection mode, star clicks might still trigger
-        # activation.
         if self.props.selection_mode:
             path, col, cell_x, cell_y = self._view.get_path_at_pos(x, y)
             iter_ = self.model.get_iter(path)
diff --git a/gnomemusic/widgets/starhandlerwidget.py b/gnomemusic/widgets/starhandlerwidget.py
index 41c5c07f..b4203bf5 100644
--- a/gnomemusic/widgets/starhandlerwidget.py
+++ b/gnomemusic/widgets/starhandlerwidget.py
@@ -137,6 +137,9 @@ class StarHandlerWidget(object):
     @log
     def _on_star_toggled(self, widget, path):
         """Called if a star is clicked"""
+        if self._parent.props.selection_mode:
+            return
+
         try:
             _iter = self._parent.model.get_iter(path)
         except TypeError:


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]