[gnome-software/gnome-3-30] systemd updates: Keep trying to trigger updates if the first app was wrong



commit b23a9a7b25d691cea6de4221f8a21a50bc0b749b
Author: Kalev Lember <klember redhat com>
Date:   Mon Dec 17 12:43:06 2018 +0100

    systemd updates: Keep trying to trigger updates if the first app was wrong
    
    When we moved the update triggering form update_app() to update() we
    forgot to change one immediate return to continue the loop.
    
    While at this, also fix a misleading comment -- non-proxy apps are not
    odd at all because we put individual app updates separately.

 plugins/packagekit/gs-plugin-systemd-updates.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
---
diff --git a/plugins/packagekit/gs-plugin-systemd-updates.c b/plugins/packagekit/gs-plugin-systemd-updates.c
index a0478298..0d2cba25 100644
--- a/plugins/packagekit/gs-plugin-systemd-updates.c
+++ b/plugins/packagekit/gs-plugin-systemd-updates.c
@@ -284,9 +284,12 @@ gs_plugin_update (GsPlugin *plugin,
                GsApp *app = gs_app_list_index (list, i);
                GsAppList *related = gs_app_get_related (app);
 
-               /* not a proxy, which is somewhat odd... */
-               if (!gs_app_has_quirk (app, AS_APP_QUIRK_IS_PROXY))
-                       return _systemd_trigger_app (plugin, app, cancellable, error);
+               /* try to trigger this app */
+               if (!gs_app_has_quirk (app, AS_APP_QUIRK_IS_PROXY)) {
+                       if (!_systemd_trigger_app (plugin, app, cancellable, error))
+                               return FALSE;
+                       continue;
+               }
 
                /* try to trigger each related app */
                for (guint j = 0; j < gs_app_list_length (related); j++) {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]