[glib/glib-2-58: 2/5] gdbus-codegen: don't sort args in --interface-info-body



commit 4c4acb6fbe3fbbfac359f19d69dd175e007f019c
Author: Will Thompson <will willthompson co uk>
Date:   Thu Dec 6 17:28:09 2018 +0000

    gdbus-codegen: don't sort args in --interface-info-body
    
    Previously, method and signal arguments were sorted by name, which
    (assuming you don't happen to give your arguments
    lexicographically-ordered names) means the generated signatures were
    incorrect when there is more than 1 argument.
    
    While sorting the methods and signals themselves (and properties, and
    annotations on all these) is fine, it's easiest to not sort anything.

 gio/gdbus-2.0/codegen/codegen.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/gio/gdbus-2.0/codegen/codegen.py b/gio/gdbus-2.0/codegen/codegen.py
index 22559bd37..144fa4283 100644
--- a/gio/gdbus-2.0/codegen/codegen.py
+++ b/gio/gdbus-2.0/codegen/codegen.py
@@ -700,7 +700,7 @@ class InterfaceInfoBodyCodeGenerator:
     def generate_array(self, array_name_lower, element_type, elements):
         self.outfile.write('const %s * const %s[] =\n' % (element_type, array_name_lower))
         self.outfile.write('{\n')
-        for (_, name) in sorted(elements, key=utils.version_cmp_key):
+        for (_, name) in elements:
             self.outfile.write('  &%s,\n' % name)
         self.outfile.write('  NULL,\n')
         self.outfile.write('};\n')


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]