[gnome-settings-daemon/wip/carlosg/do-not-overwrite-error: 2/2] power: Avoid setting error twice
- From: Benjamin Berg <bberg src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-settings-daemon/wip/carlosg/do-not-overwrite-error: 2/2] power: Avoid setting error twice
- Date: Mon, 17 Dec 2018 18:47:59 +0000 (UTC)
commit cfefb393ff2780090d7af5cfcbcd54e914a52af0
Author: Carlos Garnacho <carlosg gnome org>
Date: Mon Dec 17 19:22:09 2018 +0100
power: Avoid setting error twice
Setting keyboard brightness either returns TRUE or FALSE plus an
error. We don't need to set a default one at all here.
Related: https://gitlab.gnome.org/GNOME/gnome-settings-daemon/merge_requests/28
plugins/power/gsd-power-manager.c | 2 --
1 file changed, 2 deletions(-)
---
diff --git a/plugins/power/gsd-power-manager.c b/plugins/power/gsd-power-manager.c
index ebafaa84..246dd9c3 100644
--- a/plugins/power/gsd-power-manager.c
+++ b/plugins/power/gsd-power-manager.c
@@ -2980,8 +2980,6 @@ handle_set_property_other (GsdPowerManager *manager,
backlight_iface_emit_changed (manager, GSD_POWER_DBUS_INTERFACE_KEYBOARD,
brightness_value, "set property");
return TRUE;
} else {
- g_set_error (error, G_DBUS_ERROR, G_DBUS_ERROR_FAILED,
- "Setting %s.%s failed", interface_name, property_name);
return FALSE;
}
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]