[gnome-settings-daemon/wip/carlosg/do-not-overwrite-error] power: Avoid setting error twice



commit 097bf4b4d53319ddb38766fc27ddc67847d3f531
Author: Carlos Garnacho <carlosg gnome org>
Date:   Mon Dec 17 19:22:09 2018 +0100

    power: Avoid setting error twice
    
    Setting keyboard brightness either returns TRUE or FALSE plus an
    error. We don't need to set a default one at all here.
    
    Related: https://gitlab.gnome.org/GNOME/gnome-settings-daemon/merge_requests/28

 plugins/power/gsd-power-manager.c | 2 --
 1 file changed, 2 deletions(-)
---
diff --git a/plugins/power/gsd-power-manager.c b/plugins/power/gsd-power-manager.c
index ebafaa84..246dd9c3 100644
--- a/plugins/power/gsd-power-manager.c
+++ b/plugins/power/gsd-power-manager.c
@@ -2980,8 +2980,6 @@ handle_set_property_other (GsdPowerManager *manager,
                         backlight_iface_emit_changed (manager, GSD_POWER_DBUS_INTERFACE_KEYBOARD, 
brightness_value, "set property");
                         return TRUE;
                 } else {
-                        g_set_error (error, G_DBUS_ERROR, G_DBUS_ERROR_FAILED,
-                                     "Setting %s.%s failed", interface_name, property_name);
                         return FALSE;
                 }
         }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]