[meld/deprecation-cleanup] filediff: Remove current-diff-changed signal
- From: Kai Willadsen <kaiw src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [meld/deprecation-cleanup] filediff: Remove current-diff-changed signal
- Date: Sun, 9 Dec 2018 21:31:55 +0000 (UTC)
commit 1724d0344157afd8eac6c2e0162e63fc2558ae97
Author: Kai Willadsen <kai willadsen gmail com>
Date: Sun Dec 9 06:55:11 2018 +1000
filediff: Remove current-diff-changed signal
It was only used within FileDiff, so there's really no point to it. We
can easily add it back once this signal migration is done if it turns
out to be useful in some way.
meld/filediff.py | 5 ++---
meld/melddoc.py | 2 --
2 files changed, 2 insertions(+), 5 deletions(-)
---
diff --git a/meld/filediff.py b/meld/filediff.py
index b8d502f1..ab2d3bf8 100644
--- a/meld/filediff.py
+++ b/meld/filediff.py
@@ -194,7 +194,6 @@ class FileDiff(MeldDoc, Component):
self.set_num_panes(num_panes)
self.cursor = CursorDetails()
- self.connect("current-diff-changed", self.on_current_diff_changed)
for t in self.textview:
t.connect("focus-in-event", self.on_current_diff_changed)
t.connect("focus-out-event", self.on_current_diff_changed)
@@ -378,7 +377,7 @@ class FileDiff(MeldDoc, Component):
chunk, prev, next_ = self.linediffer.locate_chunk(pane, line)
if chunk != self.cursor.chunk or force:
self.cursor.chunk = chunk
- self.emit("current-diff-changed")
+ self.on_current_diff_changed()
if prev != self.cursor.prev or next_ != self.cursor.next or force:
self.emit(
"next-diff-changed", prev is not None, next_ is not None)
@@ -400,7 +399,7 @@ class FileDiff(MeldDoc, Component):
self.cursor.next_conflict = next_conflict
self.cursor.line, self.cursor.offset = line, offset
- def on_current_diff_changed(self, widget, *args):
+ def on_current_diff_changed(self, *args):
pane = self._get_focused_pane()
if pane != -1:
# While this *should* be redundant, it's possible for focus pane
diff --git a/meld/melddoc.py b/meld/melddoc.py
index 723d8ec9..f5f7aa3f 100644
--- a/meld/melddoc.py
+++ b/meld/melddoc.py
@@ -78,8 +78,6 @@ class MeldDoc(LabeledObjectMixin, GObject.GObject):
'create-diff': (GObject.SignalFlags.RUN_FIRST, None,
(GObject.TYPE_PYOBJECT,
GObject.TYPE_PYOBJECT)),
- 'current-diff-changed': (GObject.SignalFlags.RUN_FIRST, None,
- ()),
'next-diff-changed': (GObject.SignalFlags.RUN_FIRST, None,
(bool, bool)),
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]