[gjs: 6/10] boxed: Fix comments
- From: Cosimo Cecchi <cosimoc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gjs: 6/10] boxed: Fix comments
- Date: Sun, 2 Dec 2018 02:09:28 +0000 (UTC)
commit 6aa82361d71daa12404582d51523e6443fc51218
Author: Philip Chimento <philip chimento gmail com>
Date: Sat Dec 1 13:08:57 2018 -0800
boxed: Fix comments
One of these comments is outdated. There are no longer any get/set
property hooks.
The other needs some clarification, as it looks like it is not doing
error handling correctly, but it actually is. It does not throw a JS
exception.
gi/boxed.cpp | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
---
diff --git a/gi/boxed.cpp b/gi/boxed.cpp
index eaae200b..82dfe86e 100644
--- a/gi/boxed.cpp
+++ b/gi/boxed.cpp
@@ -134,8 +134,8 @@ boxed_resolve(JSContext *context,
* per-instance props that we want to define on the
* JSObject. Generally we do not want to cache these in JS, we
* want to always pull them from the C object, or JS would not
- * see any changes made from C. So we use the get/set prop
- * hooks, not this resolve hook.
+ * see any changes made from C. So we use the property accessors, not
+ * this resolve hook.
*/
*resolved = false;
return true;
@@ -179,8 +179,9 @@ boxed_resolve(JSContext *context,
return true;
}
-/* Check to see if JS::Value passed in is another Boxed object of the same,
- * and if so, retrieves the Boxed private structure for it.
+/* Check to see if JS::Value passed in is another Boxed object of the same type,
+ * and if so, retrieve the Boxed private structure for it. This function does
+ * not throw any JS exceptions.
*/
GJS_USE
static bool
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]