[extensions-web] django: reverse() with dot strings is deprecated



commit 85053cf3c7e4c7d6fe0e07b391111089eb218326
Author: Yuri Konotopov <ykonotopov gnome org>
Date:   Sat Dec 1 23:53:40 2018 +0400

    django: reverse() with dot strings is deprecated

 sweettooth/errorreports/tests.py | 4 ++--
 sweettooth/errorreports/views.py | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/sweettooth/errorreports/tests.py b/sweettooth/errorreports/tests.py
index 23c8563..297666e 100644
--- a/sweettooth/errorreports/tests.py
+++ b/sweettooth/errorreports/tests.py
@@ -5,7 +5,7 @@ from django.contrib.auth.models import User
 from django.test import TestCase
 
 from sweettooth.extensions.models import Extension, ExtensionVersion, STATUS_ACTIVE
-from sweettooth.errorreports import models
+from sweettooth.errorreports import models, views
 
 from sweettooth.testutils import BasicUserTestCase
 
@@ -23,7 +23,7 @@ class SubmitErrorReportTestCase(BasicUserTestCase, TestCase):
 
         comment = "YOUR EXTENSION SUCKS IT BROKE"
 
-        self.client.post(reverse('sweettooth.errorreports.views.report_error',
+        self.client.post(reverse(views.report_error,
                                  kwargs=dict(pk=extension.pk)),
                          dict(comment=comment), follow=True)
 
diff --git a/sweettooth/errorreports/views.py b/sweettooth/errorreports/views.py
index 18b2012..5039a61 100644
--- a/sweettooth/errorreports/views.py
+++ b/sweettooth/errorreports/views.py
@@ -56,7 +56,7 @@ def view_error_report(request, obj):
                                                           show_email=can_see_reporter_email(request.user, 
obj)))
 
 def send_email_on_error_reported(sender, request, extension, report, **kwargs):
-    url = request.build_absolute_uri(reverse('sweettooth.errorreports.views.view_error_report',
+    url = request.build_absolute_uri(reverse(view_error_report,
                                              kwargs=dict(pk=report.pk)))
 
     data = dict(extension=extension,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]