[mutter/gnome-3-28] clutter-actor: Fix uninitialized matrix multiply
- From: Marco Trevisan <marcotrevi src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [mutter/gnome-3-28] clutter-actor: Fix uninitialized matrix multiply
- Date: Fri, 31 Aug 2018 15:34:05 +0000 (UTC)
commit 4ca83f3c473a28e3051330acd1fa1e8c98d10f08
Author: Daniel van Vugt <daniel van vugt canonical com>
Date: Wed May 23 05:40:50 2018 +0000
clutter-actor: Fix uninitialized matrix multiply
`modelview` is uninitialized and the `apply` function just multiplies it.
What we really want is to initialize `modelview` so replace `apply` with
`get`.
Who knows what bugs this may have caused...
(cherry picked from commit 62c67be4c832b8787907581e90db0cde19423b16)
clutter/clutter/clutter-actor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/clutter/clutter/clutter-actor.c b/clutter/clutter/clutter-actor.c
index 20e4f5f5d..2ba61ba9e 100644
--- a/clutter/clutter/clutter-actor.c
+++ b/clutter/clutter/clutter-actor.c
@@ -2825,7 +2825,7 @@ _clutter_actor_fully_transform_vertices (ClutterActor *self,
/* Note: we pass NULL as the ancestor because we don't just want the modelview
* that gets us to stage coordinates, we want to go all the way to eye
* coordinates */
- _clutter_actor_apply_relative_transformation_matrix (self, NULL, &modelview);
+ _clutter_actor_get_relative_transformation_matrix (self, NULL, &modelview);
/* Fetch the projection and viewport */
_clutter_stage_get_projection_matrix (CLUTTER_STAGE (stage), &projection);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]