[babl] babl: remove more missing fast path warnings



commit d6c2038e0408da355d113b9091fd4b958d57b8e4
Author: Øyvind Kolås <pippin gimp org>
Date:   Fri Aug 31 12:54:10 2018 +0200

    babl: remove more missing fast path warnings
    
    We no longer want to warn, since warnings are also triggered when the
    fast path is better than the best path found, something that happens
    when we-re finding long paths and the reference is better.
    
    Maybe we should still print warnings according to better heuristics to be able
    to warn and encourage complete fast path coverage, fast paths should still be
    able to beat the reference in a few steps.

 babl/babl-fish-path.c | 4 ++++
 babl/babl-fish.c      | 2 ++
 2 files changed, 6 insertions(+)
---
diff --git a/babl/babl-fish-path.c b/babl/babl-fish-path.c
index 71f584d..c3a2289 100644
--- a/babl/babl-fish-path.c
+++ b/babl/babl-fish-path.c
@@ -599,11 +599,13 @@ babl_fish_path2 (const Babl *source,
     {
       get_conversion_path (&pc, (Babl *) source, 0, max_path_length () + 1, tolerance);
 
+#if 0
       if (babl->fish_path.conversion_list->count)
       {
         fprintf (stderr, "babl is using a rather long chain, room exists for optimization here\n");
         babl_list_each (babl->fish_path.conversion_list, show_item, NULL);
       }
+#endif
     }
 
     /* third attempt,. at path length + 2 */
@@ -611,11 +613,13 @@ babl_fish_path2 (const Babl *source,
         max_path_length () + 2 <= BABL_HARD_MAX_PATH_LENGTH)
     {
       get_conversion_path (&pc, (Babl *) source, 0, max_path_length () + 2, tolerance);
+#if 0
       if (babl->fish_path.conversion_list->count)
       {
         fprintf (stderr, "babl is using very long chain, should be optimized\n");
         babl_list_each (babl->fish_path.conversion_list, show_item, NULL);
       }
+#endif
     }
 
     babl_in_fish_path--;
diff --git a/babl/babl-fish.c b/babl/babl-fish.c
index a530655..65c482e 100644
--- a/babl/babl-fish.c
+++ b/babl/babl-fish.c
@@ -297,8 +297,10 @@ babl_fish (const void *source,
             /* the dummy fish was created by the cache, and we need to manually
              * show a "missing fast path" warning for it on the first lookup.
              */
+#if 0
             _babl_fish_missing_fast_path_warning (ffish.fish_fish->fish.source,
                                                   ffish.fish_fish->fish.destination);
+#endif
 
             ffish.fish_fish->fish.data = NULL;
           }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]