[gnome-shell/gnome-3-28] Revert "workspaceThumbnail: rebuild thumbnails if workareas size changed"

[Jonas Ådahl <jadahl src gnome org>]

commit 67cb02d46ac28d700489c63d8640f3b4858b2368
Author: Florian Müllner <fmuellner gnome org>
Date:   Fri Jul 20 17:27:33 2018 +0200

    Revert "workspaceThumbnail: rebuild thumbnails if workareas size changed"
    
    It is unclear what the change was supposed to be fixing, but it
    broke animations of workspace additions and removals, as those
    events trigger the ::workareas-changed signal.
    
    This reverts commit c29bd46e7a7e37a83849df8b3186c84eb46679ac.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/162

 js/ui/workspaceThumbnail.js | 21 +++++----------------
 1 file changed, 5 insertions(+), 16 deletions(-)
---
diff --git a/js/ui/workspaceThumbnail.js b/js/ui/workspaceThumbnail.js
index 417296d00..eda5dc38a 100644
--- a/js/ui/workspaceThumbnail.js
+++ b/js/ui/workspaceThumbnail.js
@@ -676,7 +676,11 @@ var ThumbnailsBox = new Lang.Class({
         this._settings.connect('changed::dynamic-workspaces',
             this._updateSwitcherVisibility.bind(this));
 
-        Main.layoutManager.connect('monitors-changed', this._rebuildThumbnails.bind(this));
+        Main.layoutManager.connect('monitors-changed', () => {
+            this._destroyThumbnails();
+            if (Main.overview.visible)
+                this._createThumbnails();
+        });
     },
 
     _updateSwitcherVisibility() {
@@ -869,9 +873,6 @@ var ThumbnailsBox = new Lang.Class({
             Main.overview.connect('windows-restacked',
                                   this._syncStacking.bind(this));
 
-        this._workareasChangedId =
-            global.screen.connect('workareas-changed', this._rebuildThumbnails.bind(this));
-
         this._targetScale = 0;
         this._scale = 0;
         this._pendingScaleUpdate = false;
@@ -901,24 +902,12 @@ var ThumbnailsBox = new Lang.Class({
             this._syncStackingId = 0;
         }
 
-        if (this._workareasChangedId > 0) {
-            global.screen.disconnect(this._workareasChangedId);
-            this._workareasChangedId = 0;
-        }
-
         for (let w = 0; w < this._thumbnails.length; w++)
             this._thumbnails[w].destroy();
         this._thumbnails = [];
         this._porthole = null;
     },
 
-    _rebuildThumbnails() {
-        this._destroyThumbnails();
-
-        if (Main.overview.visible)
-            this._createThumbnails();
-    },
-
     _workspacesChanged() {
         let validThumbnails =
             this._thumbnails.filter(t => t.state <= ThumbnailState.NORMAL);