[gegl] long-shadow: process output in-place



commit 95b0f79124b7c4508538aa03c9b6bf01241ce8e4
Author: Ell <ell_se yahoo com>
Date:   Fri Aug 10 09:14:41 2018 -0400

    long-shadow: process output in-place
    
    After commit a5ce7c7051b98dc6b7149bd1c08d69bb79df0197b, we no
    longer use a sampler in the finite-shadow case, and so we can
    process the output in-place in this case too, which allows us to
    safely set GeglOperation::want_in_place to TRUE.

 operations/common/long-shadow.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)
---
diff --git a/operations/common/long-shadow.c b/operations/common/long-shadow.c
index 8cf2cf282..aa3cab9f4 100644
--- a/operations/common/long-shadow.c
+++ b/operations/common/long-shadow.c
@@ -1142,13 +1142,12 @@ gegl_op_class_init (GeglOpClass *klass)
   operation_class->get_bounding_box          = get_bounding_box;
   operation_class->get_cached_region         = get_cached_region;
 
-  /* FIXME:  we want 'threaded == TRUE, want_in_place == FALSE' for finite
-   * shadows, and 'threaded == FALSE, want_in_place == TRUE' for infinite and
-   * fading shadows.  right now, since there's no way to control these
-   * attributes dynamically, we settle for the lowest common denominator.
+  /* FIXME:  we want 'threaded == TRUE' for finite shadows, and
+   * 'threaded == FALSE' for infinite and fading shadows.  right now, there's
+   * no way to control this dynamically, so we settle for the latter.
    */
   operation_class->threaded                  = FALSE;
-  operation_class->want_in_place             = FALSE;
+  operation_class->want_in_place             = TRUE;
 
   filter_class->process                      = process;
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]