[gnumeric] SheetView: try not to crash every time we make one.



commit 8866c3e44e5a111fe151ba99991134c5d71df011
Author: Morten Welinder <terra gnome org>
Date:   Thu Apr 26 17:11:10 2018 -0400

    SheetView: try not to crash every time we make one.

 src/sheet-view.c   |    4 ++--
 src/xml-sax-read.c |    3 ++-
 2 files changed, 4 insertions(+), 3 deletions(-)
---
diff --git a/src/sheet-view.c b/src/sheet-view.c
index 6a0e13c..0ebdbea 100644
--- a/src/sheet-view.c
+++ b/src/sheet-view.c
@@ -265,6 +265,8 @@ gnm_sheet_view_init (GObject *object)
 {
        SheetView *sv = GNM_SHEET_VIEW (object);
 
+       sv->controls = g_ptr_array_new ();
+
        /* Init menu states */
        sv->enable_insert_rows = TRUE;
        sv->enable_insert_cols = TRUE;
@@ -285,8 +287,6 @@ gnm_sheet_view_init (GObject *object)
        sv->selection_mode = GNM_SELECTION_MODE_ADD;
        sv->selections_simplified = NULL;
        sv_selection_add_pos (sv, 0, 0, GNM_SELECTION_MODE_ADD);
-
-       sv->controls = g_ptr_array_new ();
 }
 
 GSF_CLASS (SheetView, gnm_sheet_view,
diff --git a/src/xml-sax-read.c b/src/xml-sax-read.c
index 33f5d82..3d1bc95 100644
--- a/src/xml-sax-read.c
+++ b/src/xml-sax-read.c
@@ -2183,7 +2183,8 @@ xml_sax_cell_content (GsfXMLIn *xin, G_GNUC_UNUSED GsfXMLBlob *blob)
                                             GINT_TO_POINTER (expr_id));
 
                if (texpr && gnm_expr_top_is_array_corner (texpr)) {
-                       g_printerr ("Shared array formula -- how did that happen?\n");
+                       g_printerr ("Shared array formula for %s -- how did that happen?\n",
+                                   cell ? cell_name (cell) : "clipboard");
                        texpr = gnm_expr_top_new (gnm_expr_copy (texpr->expr));
                        expr_id = -1;
                } else if (texpr) {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]