[gnome-build-meta] core-deps/libmusicbrainz: add a patch to fix compilation with ninja
- From: Tristan Van Berkom <tvb src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-build-meta] core-deps/libmusicbrainz: add a patch to fix compilation with ninja
- Date: Thu, 26 Apr 2018 10:47:53 +0000 (UTC)
commit 3a533458a2551880bd7becd2c1688d56fad456c3
Author: Abderrahim Kitouni <a kitouni gmail com>
Date: Sat Apr 14 10:52:22 2018 +0100
core-deps/libmusicbrainz: add a patch to fix compilation with ninja
elements/core-deps/libmusicbrainz.bst | 3 +++
files/libmusicbrainz/cmake-ninja.patch | 22 ++++++++++++++++++++++
2 files changed, 25 insertions(+)
---
diff --git a/elements/core-deps/libmusicbrainz.bst b/elements/core-deps/libmusicbrainz.bst
index cd302c3..762aa22 100644
--- a/elements/core-deps/libmusicbrainz.bst
+++ b/elements/core-deps/libmusicbrainz.bst
@@ -2,6 +2,9 @@ kind: cmake
sources:
- kind: tar
url: github_com:metabrainz/libmusicbrainz/releases/download/release-5.1.0/libmusicbrainz-5.1.0.tar.gz
+# this patch has been merged upstream and can be removed when this is updated
+- kind: patch
+ path: files/libmusicbrainz/cmake-ninja.patch
depends:
- core-deps/neon.bst
- base.bst
diff --git a/files/libmusicbrainz/cmake-ninja.patch b/files/libmusicbrainz/cmake-ninja.patch
new file mode 100644
index 0000000..fe59dc6
--- /dev/null
+++ b/files/libmusicbrainz/cmake-ninja.patch
@@ -0,0 +1,22 @@
+commit 36262d60fe92fe7a2c9bfb40e736bfcd29a6c3bd
+Author: Abderrahim Kitouni <a kitouni gmail com>
+Date: Fri Apr 13 09:56:57 2018 +0100
+
+ src/CMakelists.txt: do not use wildcards for dependencies
+
+ This is discouraged by cmake's documentation and doesn't work with the ninja generator.
+
+diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
+index 68c04e3..f7439d3 100644
+--- a/src/CMakeLists.txt
++++ b/src/CMakeLists.txt
+@@ -37,7 +37,8 @@ ADD_CUSTOM_COMMAND(
+ OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/mb5_c.cc ${CMAKE_CURRENT_BINARY_DIR}/mb5_c.h
${CMAKE_CURRENT_BINARY_DIR}/../include/musicbrainz5/mb5_c.h
+ COMMAND make-c-interface ${CMAKE_CURRENT_SOURCE_DIR} cinterface.xml ${CMAKE_CURRENT_BINARY_DIR}
mb5_c.cc mb5_c.h
+ COMMAND ${CMAKE_COMMAND} -E copy_if_different ${CMAKE_CURRENT_BINARY_DIR}/mb5_c.h
${CMAKE_CURRENT_BINARY_DIR}/../include/musicbrainz5/mb5_c.h
+- DEPENDS make-c-interface cinterface.xml *.inc
++ DEPENDS make-c-interface cinterface.xml c-int-medium-defines.inc c-int-query-source.inc
c-int-source-funcs.inc
++ c-int-medium-source.inc c-int-release-defines.inc c-int-query-defines.inc
c-int-release-source.inc
+ )
+
+ ADD_CUSTOM_TARGET(src_gen DEPENDS mb5_c.h)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]