[gnome-shell] scripting: Fix argument list of createTestWindow()
- From: Florian Müllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] scripting: Fix argument list of createTestWindow()
- Date: Wed, 25 Apr 2018 21:55:07 +0000 (UTC)
commit 581b38ecf481e50f15e1d749b9f698d58e5d1c4e
Author: Yussuf Khalil <dev pp3345 net>
Date: Wed Apr 25 23:47:06 2018 +0200
scripting: Fix argument list of createTestWindow()
Commit f285f2c6 changed Scripting.createTestWindow() to accept a parameter
object instead of a parameter list but forgot to remove the width and height
arguments. This breaks the "core" test as all windows are created with default
settings.
js/perf/hwtest.js | 6 ++----
js/ui/scripting.js | 2 +-
2 files changed, 3 insertions(+), 5 deletions(-)
---
diff --git a/js/perf/hwtest.js b/js/perf/hwtest.js
index 5a7621d92..7555a8ab2 100644
--- a/js/perf/hwtest.js
+++ b/js/perf/hwtest.js
@@ -136,8 +136,7 @@ function run() {
global.frame_finish_timestamp = true;
for (let k = 0; k < 5; k++)
- yield Scripting.createTestWindow(640, 480,
- { maximized: true });
+ yield Scripting.createTestWindow({ maximized: true });
yield Scripting.waitTestWindows();
yield Scripting.sleep(1000);
@@ -158,8 +157,7 @@ function run() {
yield Scripting.destroyTestWindows();
Main.overview.hide();
- yield Scripting.createTestWindow(640, 480,
- { maximized: true,
+ yield Scripting.createTestWindow({ maximized: true,
redraws: true});
yield Scripting.waitTestWindows();
diff --git a/js/ui/scripting.js b/js/ui/scripting.js
index e971fcd84..c53083210 100644
--- a/js/ui/scripting.js
+++ b/js/ui/scripting.js
@@ -133,7 +133,7 @@ function _callRemote(obj, method, ...args) {
* because of the normal X asynchronous mapping process, to actually wait
* until the window has been mapped and exposed, use waitTestWindows().
*/
-function createTestWindow(width, height, params) {
+function createTestWindow(params) {
params = Params.parse(params, { width: 640,
height: 480,
alpha: false,
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]