[gimp] Bug 795369 - crop tool not changing from landscape to portrait ...



commit ee7554678e461b4bb20b0f7f64b85fcf99c29df1
Author: Ell <ell_se yahoo com>
Date:   Thu Apr 19 15:46:58 2018 -0400

    Bug 795369 - crop tool not changing from landscape to portrait ...
    
    ... when using default aspect ratio
    
    The call to
    gimp_{crop,rectangle_select}_tool_update_option_defaults() when
    starting the crop/rectangle-select tools seems to no longer be
    necessary, while it overrides user modification to the default
    ratio's landscape/portrait orinetation (which only really matters
    for the crop tool, since the rectangle-select tools' default ratio
    is 1:1).  Fix this by simply removing the call.

 app/tools/gimpcroptool.c            |    2 --
 app/tools/gimprectangleselecttool.c |    2 --
 2 files changed, 0 insertions(+), 4 deletions(-)
---
diff --git a/app/tools/gimpcroptool.c b/app/tools/gimpcroptool.c
index 7c3176e..351ae81 100644
--- a/app/tools/gimpcroptool.c
+++ b/app/tools/gimpcroptool.c
@@ -406,8 +406,6 @@ gimp_crop_tool_start (GimpCropTool *crop_tool,
   gimp_tool_rectangle_set_constraint (GIMP_TOOL_RECTANGLE (widget),
                                       gimp_crop_tool_get_constraint (crop_tool));
 
-  gimp_crop_tool_update_option_defaults (crop_tool, TRUE);
-
   g_signal_connect (widget, "changed",
                     G_CALLBACK (gimp_crop_tool_rectangle_changed),
                     crop_tool);
diff --git a/app/tools/gimprectangleselecttool.c b/app/tools/gimprectangleselecttool.c
index aa670bd..50c4584 100644
--- a/app/tools/gimprectangleselecttool.c
+++ b/app/tools/gimprectangleselecttool.c
@@ -746,8 +746,6 @@ gimp_rectangle_select_tool_start (GimpRectangleSelectTool *rect_tool,
                                   G_CALLBACK (gimp_rectangle_select_tool_auto_shrink),
                                   rect_tool);
 
-  gimp_rectangle_select_tool_update_option_defaults (rect_tool, TRUE);
-
   g_signal_connect (widget, "response",
                     G_CALLBACK (gimp_rectangle_select_tool_rectangle_response),
                     rect_tool);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]