[gnome-shell/wip/fmuellner/volume-change-feedback: 59/59] slider: Stop emulating drags in key handling



commit 684327137981514b8dd33f4b513cbd4185b48a10
Author: Florian Müllner <fmuellner gnome org>
Date:   Mon Feb 26 20:57:10 2018 +0100

    slider: Stop emulating drags in key handling
    
    Emitting ::drag-end after changing the slider value via arrow keys
    was a cheap way to make the sound feedback work for keyboard input.
    But now that the volume indicator plays the sound on ::value-changed
    as well, we can stop doing that - after all, key presses aren't drags.
    
    Besides that, this will make the limiting of feedback to actual volume
    changes from the previous commit work for key events as well.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/issues/53

 js/ui/slider.js | 2 --
 1 file changed, 2 deletions(-)
---
diff --git a/js/ui/slider.js b/js/ui/slider.js
index 9853929eb..30295b455 100644
--- a/js/ui/slider.js
+++ b/js/ui/slider.js
@@ -232,9 +232,7 @@ var Slider = new Lang.Class({
             let delta = key == Clutter.KEY_Right ? 0.1 : -0.1;
             this._value = Math.max(0, Math.min(this._value + delta, 1));
             this.actor.queue_repaint();
-            this.emit('drag-begin');
             this.emit('value-changed', this._value);
-            this.emit('drag-end');
             return Clutter.EVENT_STOP;
         }
         return Clutter.EVENT_PROPAGATE;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]