[gimp] Bug 795177 - seg fault with clone tool



commit ff34965faf98f1d533b5b38143d534a7f2496a3b
Author: Ell <ell_se yahoo com>
Date:   Fri Apr 13 09:56:20 2018 -0400

    Bug 795177 - seg fault with clone tool
    
    Don't flush the source pickable in gimp_source_core_motion(), as
    this introduces a race condition between the paint thread and the
    display-update timeout, when the source pickable is the image
    containing the target drawable.
    
    Flushing the source pickable shouldn't be currently necessary, and
    either way, should happen during initialization.

 app/paint/gimpsourcecore.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
---
diff --git a/app/paint/gimpsourcecore.c b/app/paint/gimpsourcecore.c
index b271510..1551d8d 100644
--- a/app/paint/gimpsourcecore.c
+++ b/app/paint/gimpsourcecore.c
@@ -418,8 +418,6 @@ gimp_source_core_motion (GimpSourceCore   *source_core,
           base_src_offset_x += off_x;
           base_src_offset_y += off_y;
         }
-
-      gimp_pickable_flush (src_pickable);
     }
 
   gimp_brush_core_eval_transform_dynamics (GIMP_BRUSH_CORE (paint_core),


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]