[geary/geary-0.12] Fix composer detach button position & visibility on custom setups.

[Michael Gratton <mjog src gnome org>]

commit 6be70ffec70eb962f3e4e4522b82caa2f742073b
Author: Michael James Gratton <mike vee net>
Date:   Thu Apr 12 11:36:18 2018 +1000

    Fix composer detach button position & visibility on custom setups.
    
    Fixes Bug 793710.
    
    * src/client/composer/composer-headerbar.vala (ComposerHeaderbar): Ensure
      we actually get notified when the user changes their decoration prefs
      and update detach button location correctly.
    
    * ui/composer-headerbar.ui: Make start detach button's image visible by
      default.

 src/client/composer/composer-headerbar.vala |    6 ++++--
 ui/composer-headerbar.ui                    |    1 +
 2 files changed, 5 insertions(+), 2 deletions(-)
---
diff --git a/src/client/composer/composer-headerbar.vala b/src/client/composer/composer-headerbar.vala
index e2ff91a..a947b02 100644
--- a/src/client/composer/composer-headerbar.vala
+++ b/src/client/composer/composer-headerbar.vala
@@ -46,8 +46,10 @@ public class ComposerHeaderbar : Gtk.HeaderBar {
         bind_property("show-pending-attachments", conversation_attach_buttons, "visible",
             BindingFlags.SYNC_CREATE);
 
-        notify["decoration-layout"].connect(set_detach_button_side);
-        realize.connect(set_detach_button_side);
+        set_detach_button_side();
+        Gtk.Settings.get_default().notify["gtk-decoration-layout"].connect(
+            () => { set_detach_button_side(); }
+        );
     }
 
     public void set_recipients(string label, string tooltip) {
diff --git a/ui/composer-headerbar.ui b/ui/composer-headerbar.ui
index fb0d862..77466e8 100644
--- a/ui/composer-headerbar.ui
+++ b/ui/composer-headerbar.ui
@@ -26,6 +26,7 @@
             <property name="tooltip_text" translatable="yes">Detach (Ctrl+D)</property>
             <child>
               <object class="GtkImage" id="detach_start_image">
+                <property name="visible">True</property>
                 <property name="icon_name">detach-symbolic</property>
                 <property name="pixel-size">16</property>
               </object>