[easytag] Fix preserving of non-UI tag fields
- From: David King <davidk src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [easytag] Fix preserving of non-UI tag fields
- Date: Fri, 6 Apr 2018 07:24:56 +0000 (UTC)
commit b00ed316550df3ae94522455f56e306e659511e5
Author: David King <amigadave amigadave com>
Date: Fri Apr 6 08:14:22 2018 +0100
Fix preserving of non-UI tag fields
After refactoring of some of the tag copying functions in
9aad89da3bbe7c822eb12fb082e7d4a085eb3ed6, "other" tag fields (those not
shown in the UI, but intended to be preserved) were lost when saving a
file with modified tags. There was one instance in the refactoring where
arguments to et_file_tag_copy_other_into() should have been swapped, and
were not.
Thanks to Philippe Troin for the bug report and initial patch.
https://bugzilla.gnome.org/show_bug.cgi?id=795018
src/application_window.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/src/application_window.c b/src/application_window.c
index f1f6be6..4014fee 100644
--- a/src/application_window.c
+++ b/src/application_window.c
@@ -2080,7 +2080,7 @@ et_application_window_update_et_file_from_ui (EtApplicationWindow *self)
#endif
case APE_TAG:
FileTag = et_application_window_tag_area_create_file_tag (self);
- et_file_tag_copy_other_into (et_file->FileTag->data, FileTag);
+ et_file_tag_copy_other_into (FileTag, et_file->FileTag->data);
break;
#ifndef ENABLE_MP3
case ID3_TAG:
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]