[devhelp] Preferences: improve code of bookshelf_populate_store()

[Sébastien Wilmet <swilmet src gnome org>]

commit 85b6fee49c3626d30210a252416cb928cef07010
Author: Sébastien Wilmet <swilmet gnome org>
Date:   Fri Apr 6 07:02:05 2018 +0200

    Preferences: improve code of bookshelf_populate_store()

 src/dh-preferences.c |   11 ++++++-----
 1 files changed, 6 insertions(+), 5 deletions(-)
---
diff --git a/src/dh-preferences.c b/src/dh-preferences.c
index 3d4c00a..5362416 100644
--- a/src/dh-preferences.c
+++ b/src/dh-preferences.c
@@ -396,17 +396,18 @@ bookshelf_populate_store (DhPreferences *prefs)
 {
         DhPreferencesPrivate *priv = dh_preferences_get_instance_private (prefs);
         DhBookManager *book_manager;
+        GList *books;
         GList *l;
 
         gtk_list_store_clear (priv->bookshelf_store);
 
         book_manager = dh_book_manager_get_singleton ();
+        books = dh_book_manager_get_books (book_manager);
 
-        /* This list already comes ordered, but we don't care */
-        for (l = dh_book_manager_get_books (book_manager);
-             l;
-             l = g_list_next (l)) {
-                bookshelf_add_book_to_store (prefs, DH_BOOK (l->data));
+        /* This list already comes ordered, but we don't care. */
+        for (l = books; l != NULL; l = l->next) {
+                DhBook *cur_book = DH_BOOK (l->data);
+                bookshelf_add_book_to_store (prefs, cur_book);
         }
 }