[devhelp] Preferences: always clear GtkListStore before populating it

[Sébastien Wilmet <swilmet src gnome org>]

commit 833e951dd84726d0a6b47cc17b00b6041923ada2
Author: Sébastien Wilmet <swilmet gnome org>
Date:   Thu Apr 5 21:01:58 2018 +0200

    Preferences: always clear GtkListStore before populating it
    
    It doesn't hurt. To simplify the code.

 src/dh-preferences.c |   12 +++---------
 1 files changed, 3 insertions(+), 9 deletions(-)
---
diff --git a/src/dh-preferences.c b/src/dh-preferences.c
index f242a21..017089c 100644
--- a/src/dh-preferences.c
+++ b/src/dh-preferences.c
@@ -78,14 +78,6 @@ dh_preferences_class_init (DhPreferencesClass *klass)
         gtk_widget_class_bind_template_child_private (widget_class, DhPreferences, fixed_font_button);
 }
 
-static void
-bookshelf_clean_store (DhPreferences *prefs)
-{
-        DhPreferencesPrivate *priv = dh_preferences_get_instance_private (prefs);
-
-        gtk_list_store_clear (priv->bookshelf_store);
-}
-
 /* Tries to find, starting at 'first' (if given):
  *  - An exact match of the book
  *  - The book which should be just after our given book:
@@ -384,11 +376,14 @@ bookshelf_add_book_to_store (DhPreferences *prefs,
 static void
 bookshelf_populate_store (DhPreferences *prefs)
 {
+        DhPreferencesPrivate *priv = dh_preferences_get_instance_private (prefs);
         DhBookManager *book_manager;
         DhSettings *settings;
         GList *l;
         gboolean group_by_language;
 
+        gtk_list_store_clear (priv->bookshelf_store);
+
         book_manager = dh_book_manager_get_singleton ();
 
         settings = dh_settings_get_default ();
@@ -409,7 +404,6 @@ bookshelf_group_books_by_language_notify_cb (DhSettings    *settings,
                                              GParamSpec    *pspec,
                                              DhPreferences *prefs)
 {
-        bookshelf_clean_store (prefs);
         bookshelf_populate_store (prefs);
 }