[devhelp] build: fix warning with latest version of meson



commit b36c4a194c59b1a2dfe9793d5de2ac32054662ab
Author: Sébastien Wilmet <swilmet gnome org>
Date:   Sun Apr 1 13:40:05 2018 +0200

    build: fix warning with latest version of meson
    
    The warning was:
    
    WARNING: -Wl,--version-script looks like a linker argument, but has_argument
    and other similar methods only support checking compiler arguments.
    Using them to check linker arguments are never supported, and results
    are likely to be wrong regardless of the compiler you are using.

 devhelp/meson.build |   10 +---------
 1 files changed, 1 insertions(+), 9 deletions(-)
---
diff --git a/devhelp/meson.build b/devhelp/meson.build
index 325579a..1f0751c 100644
--- a/devhelp/meson.build
+++ b/devhelp/meson.build
@@ -66,18 +66,10 @@ STATIC_LIBDEVHELP_DECLARED_DEP = declare_dependency(
 
 symbol_map = join_paths(meson.current_source_dir(), 'symbol.map')
 
-ldflag = '-Wl,--version-script'
-c_compiler = meson.get_compiler('c')
-
-ldflags = []
-if c_compiler.has_argument(ldflag)
-        ldflags += '@0@,@1@'.format(ldflag, symbol_map)
-endif
-
 libdevhelp = shared_library(
         'devhelp-@0@'.format(DEVHELP_API_VERSION),
         link_whole : libdevhelp_static,
-        link_args : ldflags,
+        link_args : '-Wl,--version-script,' + symbol_map,
         link_depends : symbol_map,
         version : LIBDEVHELP_LT_VERSION,
         install : true


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]