[beast: 8/9] BSE: fix bse_item_gather_items() not to forget the return value



commit 02f25c5f165e22ef2b446ba7c89216fa263ab052
Author: Tim Janik <timj gnu org>
Date:   Fri Sep 29 11:28:17 2017 +0200

    BSE: fix bse_item_gather_items() not to forget the return value
    
    Signed-off-by: Tim Janik <timj gnu org>

 bse/bseitem.cc |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)
---
diff --git a/bse/bseitem.cc b/bse/bseitem.cc
index 4d19e35..09dfeaf 100644
--- a/bse/bseitem.cc
+++ b/bse/bseitem.cc
@@ -283,14 +283,15 @@ bse_item_compat_setup (BseItem         *self,
     BSE_ITEM_GET_CLASS (self)->compat_setup (self, vmajor, vminor, vmicro);
 }
 
-typedef struct {
+struct GatherData {
   BseItem              *item;
   void                 *data;
-  Bse::ItemSeq          iseq;
+  Bse::ItemSeq         &iseq;
   GType                 base_type;
   BseItemCheckContainer ccheck;
   BseItemCheckProxy     pcheck;
-} GatherData;
+  GatherData (Bse::ItemSeq &is) : iseq (is) {}
+};
 
 static gboolean
 gather_child (BseItem *child,
@@ -320,13 +321,12 @@ gather_child (BseItem *child,
 static void
 bse_item_gather_items (BseItem *item, Bse::ItemSeq &iseq, GType base_type, BseItemCheckContainer ccheck, 
BseItemCheckProxy pcheck, void *data)
 {
-  GatherData gdata;
+  GatherData gdata (iseq);
   assert_return (BSE_IS_ITEM (item));
   assert_return (g_type_is_a (base_type, BSE_TYPE_ITEM));
 
   gdata.item = item;
   gdata.data = data;
-  gdata.iseq = iseq;
   gdata.base_type = base_type;
   gdata.ccheck = ccheck;
   gdata.pcheck = pcheck;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]