[gparted] Stop nicing external commands run by the DMRaid module (#788007)
- From: Curtis Gedak <gedakc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gparted] Stop nicing external commands run by the DMRaid module (#788007)
- Date: Mon, 25 Sep 2017 15:32:59 +0000 (UTC)
commit 25d2aa341c9887d9d5fa0ca6ace6e583f23b651d
Author: Mike Fleetwood <mike fleetwood googlemail com>
Date: Thu Sep 21 19:15:47 2017 +0100
Stop nicing external commands run by the DMRaid module (#788007)
No other commands run by GParted are niced, so stop nicing commands run
from the DMRaid module.
I think nicing of possibly long running file system modification
commands would have made virtually no difference because "nice -n 19"
lowered the CPU priority, but such command would be I/O bound.
History:
Nicing of file system modification commands was added by this commit
from 2006-08-21:
82e6f6b132fd7960950a71a2af2db6ef93fde583
added nice -n 19, so that all extensive filesystem operations will be
Nicing of DMRaid operations was copied into the DMRaid module when it
was added here in 2009-03-14:
5865c92dc054dc87739e6a70b21f91825f214c9e
Added new class for dmraid support
Nicing was removed from file system modification commands with this
commit from 2013-02-22:
52a2a9b00a32996921ace055e71d0e09fb33c5fe
Reduce threading (#685740)
Bug 788007 - Remove minor bits of legacy from DMRaid module
src/DMRaid.cc | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/src/DMRaid.cc b/src/DMRaid.cc
index b75e5d1..456490d 100644
--- a/src/DMRaid.cc
+++ b/src/DMRaid.cc
@@ -151,7 +151,7 @@ int DMRaid::execute_command( const Glib::ustring & command, OperationDetail & op
operationdetail .add_child( OperationDetail( command, STATUS_NONE, FONT_BOLD_ITALIC ) ) ;
- int exit_status = Utils::execute_command( "nice -n 19 " + command, output, error ) ;
+ int exit_status = Utils::execute_command( command, output, error );
if ( ! output .empty() )
operationdetail .get_last_child() .add_child( OperationDetail( output, STATUS_NONE,
FONT_ITALIC ) ) ;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]