[gnome-software] gs-category-page: Clear handler IDs when disconnecting



commit b2f5d612c9b71ce37d754d6f8d40eceabfbeeb36
Author: Iain Lane <iain orangesquash org uk>
Date:   Thu Sep 21 18:09:13 2017 +0100

    gs-category-page: Clear handler IDs when disconnecting
    
    To avoid some warnings and accidental double disconnections.

 src/gs-category-page.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)
---
diff --git a/src/gs-category-page.c b/src/gs-category-page.c
index 8c28c5a..32fc12c 100644
--- a/src/gs-category-page.c
+++ b/src/gs-category-page.c
@@ -329,13 +329,17 @@ gs_category_page_reload (GsPage *page)
                gtk_widget_set_visible (self->subcats_sort_button, TRUE);
        }
 
-       if (self->sort_rating_handler_id > 0)
+       if (self->sort_rating_handler_id > 0) {
                g_signal_handler_disconnect (self->sort_rating_button,
                                             self->sort_rating_handler_id);
+               self->sort_rating_handler_id = 0;
+       }
 
-       if (self->sort_name_handler_id > 0)
+       if (self->sort_name_handler_id > 0) {
                g_signal_handler_disconnect (self->sort_name_button,
                                             self->sort_name_handler_id);
+               self->sort_name_handler_id = 0;
+       }
 
        gs_container_remove_all (GTK_CONTAINER (self->category_detail_box));
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]