[gnome-font-viewer/wip/matthiasc/more-info: 2/6] Do multiline labels differently



commit ad22b2c09fac1d5ffe785256d29b0ffc5a5e71dc
Author: Matthias Clasen <mclasen redhat com>
Date:   Sat Sep 16 10:39:34 2017 -0400

    Do multiline labels differently
    
    I think we should show multiple lines of text when it is
    present. Cutting things off is just rude. But we don't
    want to break the UI by producing an enormous dialog,
    so don't allow more than 10 lines per label.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=787759

 src/font-view.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)
---
diff --git a/src/font-view.c b/src/font-view.c
index 613c223..a0bdeb4 100644
--- a/src/font-view.c
+++ b/src/font-view.c
@@ -175,11 +175,12 @@ add_row (GtkWidget *grid,
     gtk_label_set_line_wrap (GTK_LABEL (label), TRUE);
     gtk_label_set_xalign (GTK_LABEL (label), 0.0);
 
+    gtk_label_set_ellipsize (GTK_LABEL (label), PANGO_ELLIPSIZE_END);
+    gtk_label_set_max_width_chars (GTK_LABEL (label), 64);
     if (multiline && g_utf8_strlen (value, -1) > 64) {
-        gtk_label_set_width_chars (GTK_LABEL (label), 64);
-        gtk_label_set_ellipsize (GTK_LABEL (label), PANGO_ELLIPSIZE_END);
+       gtk_label_set_width_chars (GTK_LABEL (label), 64);
     }
-    gtk_label_set_max_width_chars (GTK_LABEL (label), 64);
+    gtk_label_set_lines (GTK_LABEL (label), multiline ? 10 : 1);
 
     gtk_grid_attach_next_to (GTK_GRID (grid), label, 
                              name_w, GTK_POS_RIGHT,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]