GNOME.org
 

[gxml] Removing more compilation related warnings

commit ab182f451405a630f4bfff43f9eb19bcebc5eaed
Author: Daniel Espinosa <esodan gmail com>
Date:   Mon Sep 4 10:12:16 2017 -0500

    Removing more compilation related warnings

 test/HtmlDocumentTest.vala             |    5 -----
 test/SerializableGeeArrayListTest.vala |    4 +++-
 test/SerializableGeeHashMapTest.vala   |    4 +++-
 test/SerializableObjectModelTest.vala  |    1 +
 test/SerializableTest.vala             |    1 +
 5 files changed, 8 insertions(+), 7 deletions(-)
---
diff --git a/test/HtmlDocumentTest.vala b/test/HtmlDocumentTest.vala
index 630b421..d35f415 100644
--- a/test/HtmlDocumentTest.vala
+++ b/test/HtmlDocumentTest.vala
@@ -71,7 +71,6 @@ class HtmlDocumentTest : GXmlTest {
                        }
                });
                Test.add_func ("/gxml/htmldocument/fom_string_doc", () => {
-                       try {
                                var sdoc = "<!doctype html>
 <html>
 <head>
@@ -106,10 +105,6 @@ class HtmlDocumentTest : GXmlTest {
                                var s = doc.to_html ();
                                message (s);
                                assert ("style>\n  * { color: red; }\n  </style>" in s);
-                       } catch (GLib.Error e){
-                               Test.message ("ERROR: "+e.message);
-                               assert_not_reached ();
-                       }
                });
                // Test.add_func ("/gxml/htmldocument/uri", () => {
                //      try {
diff --git a/test/SerializableGeeArrayListTest.vala b/test/SerializableGeeArrayListTest.vala
index 361d854..1aeb4dc 100644
--- a/test/SerializableGeeArrayListTest.vala
+++ b/test/SerializableGeeArrayListTest.vala
@@ -197,8 +197,10 @@ class SerializableGeeArrayListTest : GXmlTest
         c.deserialize (root);
         assert (c.size == 3);
         int count_elements = 0;
-        foreach (AElement e in c)
+        foreach (AElement e in c) {
+          assert (e != null);
           count_elements++;
+        }
         assert (count_elements == 3);
         string[] s = {"Big","Small","Wall"};
 #if DEBUG
diff --git a/test/SerializableGeeHashMapTest.vala b/test/SerializableGeeHashMapTest.vala
index 9de176c..f9fa873 100644
--- a/test/SerializableGeeHashMapTest.vala
+++ b/test/SerializableGeeHashMapTest.vala
@@ -309,8 +309,10 @@ class SerializableGeeHashMapTest : GXmlTest
         assert (sc.storage != null);
         assert (sc.storage.size == 5);
         int i = 0;
-        foreach (Space s in sc.storage.values)
+        foreach (Space s in sc.storage.values) {
+          assert (s != null);
           i++;
+        }
         assert (i == 5);
         var s1 = sc.storage.get ("Big");
         assert (s1 != null);
diff --git a/test/SerializableObjectModelTest.vala b/test/SerializableObjectModelTest.vala
index 7b09139..bdc6da3 100644
--- a/test/SerializableObjectModelTest.vala
+++ b/test/SerializableObjectModelTest.vala
@@ -126,6 +126,7 @@ public class Package : ObjectModel
     source = "Mexico";
     destiny = "World";
     ((Serializable) this).serialize_unknown_property.connect ( (element, prop, out node) => {
+      node = null;
       //GLib.message (@"Serializing Unknown Property: $(prop.name) | $(prop.get_nick ())");
       if (prop.name == "tags")
       {
diff --git a/test/SerializableTest.vala b/test/SerializableTest.vala
index de5c53e..ff141a6 100644
--- a/test/SerializableTest.vala
+++ b/test/SerializableTest.vala
@@ -101,6 +101,7 @@ public class SerializableCapsicum : GXml.SerializableObjectModel {
        }
        private void serialize_unknown_property_type (GXml.Node elem, ParamSpec prop, out GXml.Node node)
        {
+               node = null;
                try {
                        var element = (GElement) elem;
                        var doc = element.document;
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]