[gtk+] Adwaita: Fix ineffective theming of switch slider
- From: Daniel Boles <dboles src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk+] Adwaita: Fix ineffective theming of switch slider
- Date: Sun, 3 Sep 2017 13:03:43 +0000 (UTC)
commit 68631d6dbddf32daf59683a52cfad332d63e217b
Author: Daniel Boles <dboles src gnome org>
Date: Sun Sep 3 13:53:48 2017 +0100
Adwaita: Fix ineffective theming of switch slider
in a specific case, which was applying .slider as a class on the parent
switch, instead of correctly selecting on its child node named slider.
This makes the border on the outside of a switch in a selected listbox
row look better in the light variant. Since the code was never removed,
it was clearly meant to work, and making it work is a clear improvement.
gtk/theme/Adwaita/_common.scss | 6 +++---
gtk/theme/Adwaita/gtk-contained.css | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
---
diff --git a/gtk/theme/Adwaita/_common.scss b/gtk/theme/Adwaita/_common.scss
index 7fedbcd..c72a2bf 100644
--- a/gtk/theme/Adwaita/_common.scss
+++ b/gtk/theme/Adwaita/_common.scss
@@ -2608,10 +2608,10 @@ switch {
&:backdrop { border-color: $selected_borders_color; }
- &.slider:dir(rtl) { border-left-color: $borders_color; }
- &.slider:dir(ltr) { border-right-color: $borders_color; }
+ slider:dir(rtl) { border-left-color: $borders_color; }
+ slider:dir(ltr) { border-right-color: $borders_color; }
- &.slider { &:checked, & { border-color: $selected_borders_color; } }
+ slider { &:checked, & { border-color: $selected_borders_color; } }
}
}
}
diff --git a/gtk/theme/Adwaita/gtk-contained.css b/gtk/theme/Adwaita/gtk-contained.css
index 55dd609..a872740 100644
--- a/gtk/theme/Adwaita/gtk-contained.css
+++ b/gtk/theme/Adwaita/gtk-contained.css
@@ -1089,11 +1089,11 @@ row:selected switch { box-shadow: none; border-color: #184472; }
row:selected switch:backdrop { border-color: #184472; }
-row:selected switch.slider:dir(rtl) { border-left-color: #b6b6b3; }
+row:selected switch slider:dir(rtl) { border-left-color: #b6b6b3; }
-row:selected switch.slider:dir(ltr) { border-right-color: #b6b6b3; }
+row:selected switch slider:dir(ltr) { border-right-color: #b6b6b3; }
-row:selected switch.slider:checked, row:selected switch.slider { border-color: #184472; }
+row:selected switch slider:checked, row:selected switch slider { border-color: #184472; }
/************************* Check and Radio items * */
.view.content-view.check:not(list), iconview.content-view.check:not(list), .content-view .tile
check:not(list) { -gtk-icon-shadow: none; -gtk-icon-source:
-gtk-scaled(url("assets/checkbox-selectionmode.png"), url("assets/checkbox-selectionmode 2 png"));
background-color: transparent; min-width: 40px; min-height: 40px; background-image: none; transition: none;
box-shadow: none; border-width: 0; }
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]