[gnome-builder] code-index: Avoid segfault when indexing is stopped.



commit 64ed630d0b6ca1a510beda367f951d85ff958d00
Author: Anoop Chandu <anoopchandu96 gmail com>
Date:   Sat Sep 2 18:27:16 2017 +0530

    code-index: Avoid segfault when indexing is stopped.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=786700

 plugins/code-index/ide-code-index-builder.c |    2 +-
 plugins/code-index/ide-code-index-service.c |    6 ------
 2 files changed, 1 insertions(+), 7 deletions(-)
---
diff --git a/plugins/code-index/ide-code-index-builder.c b/plugins/code-index/ide-code-index-builder.c
index 2e80499..d6d5e5c 100644
--- a/plugins/code-index/ide-code-index-builder.c
+++ b/plugins/code-index/ide-code-index-builder.c
@@ -599,7 +599,7 @@ ide_code_index_builder_build_cb3 (GObject      *object,
   if (ide_code_index_builder_index_directories_finish (self, result, &error))
     g_task_return_boolean (main_task, TRUE);
   else
-    g_task_return_error (main_task, error);
+    g_task_return_error (main_task, g_steal_pointer (&error));
 }
 
 static void
diff --git a/plugins/code-index/ide-code-index-service.c b/plugins/code-index/ide-code-index-service.c
index 69d8112..7361b7b 100644
--- a/plugins/code-index/ide-code-index-service.c
+++ b/plugins/code-index/ide-code-index-service.c
@@ -381,8 +381,6 @@ ide_code_index_service_context_loaded (IdeService *service)
                            G_CONNECT_SWAPPED);
 
   ide_code_index_service_build (self, workdir, TRUE, 1);
-
-  g_debug ("context loaded");
 }
 
 static void
@@ -391,8 +389,6 @@ ide_code_index_service_start (IdeService *service)
   IdeCodeIndexService *self = (IdeCodeIndexService *)service;
 
   self->stopped = FALSE;
-
-  g_debug ("service started");
 }
 
 static void
@@ -411,8 +407,6 @@ ide_code_index_service_stop (IdeService *service)
   g_queue_clear (&self->build_queue);
   g_clear_pointer (&self->build_dirs, g_hash_table_unref);
   g_clear_pointer (&self->code_indexers, g_hash_table_unref);
-
-  g_debug ("service stopped");
 }
 
 static void


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]