[gtk+/gtk-2-24] ComboBox: Add missing disconnect in menu_destroy()
- From: Daniel Boles <dboles src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk+/gtk-2-24] ComboBox: Add missing disconnect in menu_destroy()
- Date: Fri, 1 Sep 2017 15:36:58 +0000 (UTC)
commit e0e2107f356b3b512aea0fe1ad08d0c345ec58bd
Author: Daniel Boles <dboles src gnome org>
Date: Fri Sep 1 15:03:45 2017 +0100
ComboBox: Add missing disconnect in menu_destroy()
We were not disconnecting the signals from the menu (popup_widget), so
they were leaked when e.g. the mode was changed or the CB was destroyed.
gtk/gtkcombobox.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
---
diff --git a/gtk/gtkcombobox.c b/gtk/gtkcombobox.c
index 58a9682..02ca5e8 100644
--- a/gtk/gtkcombobox.c
+++ b/gtk/gtkcombobox.c
@@ -3186,10 +3186,8 @@ gtk_combo_box_menu_destroy (GtkComboBox *combo_box)
{
GtkComboBoxPrivate *priv = combo_box->priv;
- g_signal_handlers_disconnect_by_func (priv->button,
- gtk_combo_box_menu_button_press, combo_box);
- g_signal_handlers_disconnect_by_func (priv->button,
- gtk_combo_box_button_state_changed, combo_box);
+ g_signal_handlers_disconnect_by_data (priv->button, combo_box);
+ g_signal_handlers_disconnect_by_data (priv->popup_widget, combo_box);
/* unparent will remove our latest ref */
gtk_widget_unparent (priv->button);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]