[gjs] maint: Add SpiderMonkey helgrind suppression rules



commit eba8ff77a4b53e7d7b4704014105bdf0eecd9ac1
Author: Philip Chimento <philip endlessm com>
Date:   Thu Aug 31 17:30:50 2017 -0700

    maint: Add SpiderMonkey helgrind suppression rules
    
    Helgrind detects all kinds of data races in SpiderMonkey's atomic
    operations, but we can only assume that SpiderMonkey has got its atomic
    operations working correctly; these are not races in GJS, in any case.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=786995

 installed-tests/extra/gjs.supp |   58 ++++++++++++++++++++++++++++++++++++++++
 1 files changed, 58 insertions(+), 0 deletions(-)
---
diff --git a/installed-tests/extra/gjs.supp b/installed-tests/extra/gjs.supp
index 32816a6..5f10734 100644
--- a/installed-tests/extra/gjs.supp
+++ b/installed-tests/extra/gjs.supp
@@ -83,3 +83,61 @@
    fun:start_thread
    fun:clone
 }
+
+
+# SpiderMonkey data races
+
+# These are in SpiderMonkey's atomics / thread barrier stuff so presumably
+# locking is working correctly and helgrind just can't detect it?
+
+{
+   mozjs-helgrind-atomic-load-1
+   Helgrind:Race
+   fun:load
+   fun:load
+   fun:operator unsigned int
+}
+
+{
+   mozjs-helgrind-atomic-load-2
+   Helgrind:Race
+   fun:load
+   fun:load
+   fun:operator bool
+}
+
+{
+   mozjs-helgrind-atomic-store
+   Helgrind:Race
+   fun:store
+   fun:store
+   fun:operator=
+}
+
+# Presumably this one is OK since the function is called "thread safe"?!
+{
+   mozjs-helgrind-thread-safe-lookup
+   Helgrind:Race
+   ...
+   fun:lookup
+   fun:readonlyThreadsafeLookup
+   fun:readonlyThreadsafeLookup
+}
+
+{
+   mozjs-helgrind-jit-code
+   Helgrind:Race
+   obj:*
+   ...
+   fun:_ZL13EnterBaselineP9JSContextRN2js3jit12EnterJitDataE
+}
+
+{
+   mozjs-helgrind-probably-jit-code
+   Helgrind:Race
+   obj:*
+   obj:*
+   obj:*
+   obj:*
+   obj:*
+}


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]