[gnome-software/wip/ubuntu-3-22: 21/27] snap: Only feature snaps

[Robert Ancell <rancell src gnome org>]

commit f0483b24a2fed5e975b639ecccb59dee519820c6
Author: Robert Ancell <robert ancell canonical com>
Date:   Wed Aug 9 15:43:02 2017 +1200

    snap: Only feature snaps
    
    Run after the other plugins that populate featured/popular apps and remove
    them when we set ours.

 src/plugins/gs-plugin-snap.c |   15 ++++++++++++++-
 1 files changed, 14 insertions(+), 1 deletions(-)
---
diff --git a/src/plugins/gs-plugin-snap.c b/src/plugins/gs-plugin-snap.c
index 89b5eb2..d7d050b 100644
--- a/src/plugins/gs-plugin-snap.c
+++ b/src/plugins/gs-plugin-snap.c
@@ -59,11 +59,13 @@ gs_plugin_initialize (GsPlugin *plugin)
 
        gs_plugin_add_rule (plugin, GS_PLUGIN_RULE_RUN_AFTER, "desktop-categories");
        gs_plugin_add_rule (plugin, GS_PLUGIN_RULE_RUN_AFTER, "ubuntu-reviews");
+       gs_plugin_add_rule (plugin, GS_PLUGIN_RULE_RUN_AFTER, "appstream");
        gs_plugin_add_rule (plugin, GS_PLUGIN_RULE_BETTER_THAN, "packagekit");
        gs_plugin_add_rule (plugin, GS_PLUGIN_RULE_RUN_BEFORE, "icons");
 
        /* Override hardcoded popular apps */
-       gs_plugin_add_rule (plugin, GS_PLUGIN_RULE_RUN_BEFORE, "hardcoded-popular");
+       gs_plugin_add_rule (plugin, GS_PLUGIN_RULE_RUN_AFTER, "hardcoded-popular");
+       gs_plugin_add_rule (plugin, GS_PLUGIN_RULE_RUN_AFTER, "hardcoded-featured");
 }
 
 gboolean
@@ -290,6 +292,12 @@ is_banner_icon_image (const gchar *filename)
        return g_regex_match_simple ("^banner-icon(?:_[a-zA-Z0-9]{7})?\\.(?:png|jpg)$", filename, 0, 0);
 }
 
+static gboolean
+remove_cb (GsApp *app, gpointer user_data)
+{
+       return FALSE;
+}
+
 gboolean
 gs_plugin_add_featured (GsPlugin *plugin,
                        GsAppList *list,
@@ -361,6 +369,8 @@ gs_plugin_add_featured (GsPlugin *plugin,
                               background_css->str);
        gs_app_set_metadata (app, "GnomeSoftware::FeatureTile-css", css);
 
+       /* replace any other featured apps with our one */
+       gs_app_list_filter (list, remove_cb, NULL);
        gs_app_list_add (list, app);
 
        return TRUE;
@@ -379,6 +389,9 @@ gs_plugin_add_popular (GsPlugin *plugin,
        if (snaps == NULL)
                return FALSE;
 
+       /* replace any other popular apps with our one */
+       gs_app_list_filter (list, remove_cb, NULL);
+
        /* skip first snap - it is used as the featured app */
        for (i = 1; i < json_array_get_length (snaps); i++) {
                g_autoptr(GsApp) app = snap_to_app (plugin, json_array_get_object_element (snaps, i));