[gimp/gimp-2-8] Bug 786840 - Selecting last option in file association list ...

[N/A <ell src gnome org>]

commit e1c54f68ef22c153479598dace2d195b5897459b
Author: Ell <ell_se yahoo com>
Date:   Mon Oct 23 08:46:36 2017 -0400

    Bug 786840 - Selecting last option in file association list ...
    
    ... makes the list scroll down and select the next item
    
    Adjust the file association list height to be a multiple of the
    item height, to avoid this issue.
    
    (cherry picked from commit a44ef8e8666dbc92a6152f469f1704c8e1c10a55)

 build/windows/installer/gimp3264.iss |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
---
diff --git a/build/windows/installer/gimp3264.iss b/build/windows/installer/gimp3264.iss
index 322d8cf..87a2b2f 100644
--- a/build/windows/installer/gimp3264.iss
+++ b/build/windows/installer/gimp3264.iss
@@ -702,6 +702,13 @@ begin
                TabOrder := 1;
                Flat := True;
 
+                // the box's height, minus the 2-pixel border, has to be a
+                // multiple of the item height, which has to be even, otherwise
+                // clicking the last visible item may scroll to the next item,
+                // causing it to be toggled.  see bug #786840.
+                MinItemHeight := ScaleY(16) / 2 * 2;
+                Height := (Height - 4) / MinItemHeight * MinItemHeight + 4;
+
                Associations.AssociationsPage.lblAssocInfo2.Top := Height + Top;
 
                OnClick := @Associations_OnClick;