[gnome-software] Only show in-app notifications for interactive user actions
- From: Richard Hughes <rhughes src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software] Only show in-app notifications for interactive user actions
- Date: Wed, 18 Oct 2017 12:16:37 +0000 (UTC)
commit c4d1913d0e3f4d9a2f24904701a0643a5ed556ff
Author: Richard Hughes <richard hughsie com>
Date: Wed Oct 18 13:15:32 2017 +0100
Only show in-app notifications for interactive user actions
Other errors will be logged to the journal.
lib/gs-plugin-types.h | 2 +-
src/gs-application.c | 2 +-
src/gs-category-page.c | 4 ++--
src/gs-extras-page.c | 6 +++---
src/gs-installed-page.c | 2 +-
src/gs-loading-page.c | 2 +-
src/gs-moderate-page.c | 2 +-
src/gs-overview-page.c | 12 ++++++------
src/gs-search-page.c | 2 +-
src/gs-updates-page.c | 4 ++--
10 files changed, 19 insertions(+), 19 deletions(-)
---
diff --git a/lib/gs-plugin-types.h b/lib/gs-plugin-types.h
index f31dbf9..2804216 100644
--- a/lib/gs-plugin-types.h
+++ b/lib/gs-plugin-types.h
@@ -321,7 +321,7 @@ typedef enum {
/**
* GsPluginFailureFlags:
* @GS_PLUGIN_FAILURE_FLAGS_NONE: No flags set
- * @GS_PLUGIN_FAILURE_FLAGS_USE_EVENTS: Report errors out-of-band
+ * @GS_PLUGIN_FAILURE_FLAGS_USE_EVENTS: Report errors as in-app-notifications
* @GS_PLUGIN_FAILURE_FLAGS_FATAL_ANY: Abort after any plugin error
* @GS_PLUGIN_FAILURE_FLAGS_FATAL_AUTH: Abort after a authentication error
* @GS_PLUGIN_FAILURE_FLAGS_NO_CONSOLE: Do not show a message on the console
diff --git a/src/gs-application.c b/src/gs-application.c
index 9072eb4..8f48e30 100644
--- a/src/gs-application.c
+++ b/src/gs-application.c
@@ -182,7 +182,7 @@ gs_application_initialize_plugins (GsApplication *app)
if (!gs_plugin_loader_setup (app->plugin_loader,
plugin_whitelist,
plugin_blacklist,
- GS_PLUGIN_FAILURE_FLAGS_USE_EVENTS,
+ GS_PLUGIN_FAILURE_FLAGS_NONE,
NULL,
&error)) {
g_warning ("Failed to setup plugins: %s", error->message);
diff --git a/src/gs-category-page.c b/src/gs-category-page.c
index 51cf3db..b28ed9d 100644
--- a/src/gs-category-page.c
+++ b/src/gs-category-page.c
@@ -282,7 +282,7 @@ gs_category_page_set_featured_apps (GsCategoryPage *self)
plugin_job = gs_plugin_job_newv (GS_PLUGIN_ACTION_GET_CATEGORY_APPS,
"category", featured_subcat,
- "failure-flags", GS_PLUGIN_FAILURE_FLAGS_USE_EVENTS,
+ "failure-flags", GS_PLUGIN_FAILURE_FLAGS_NONE,
"refine-flags", GS_PLUGIN_REFINE_FLAGS_REQUIRE_ICON |
GS_PLUGIN_REFINE_FLAGS_REQUIRE_RATING,
NULL);
@@ -359,7 +359,7 @@ gs_category_page_reload (GsPage *page)
"category", self->subcategory,
"max-results", 50,
"filter-flags", GS_PLUGIN_REFINE_FLAGS_REQUIRE_RATING,
- "failure-flags", GS_PLUGIN_FAILURE_FLAGS_USE_EVENTS,
+ "failure-flags", GS_PLUGIN_FAILURE_FLAGS_NONE,
"refine-flags", GS_PLUGIN_REFINE_FLAGS_REQUIRE_ICON |
GS_PLUGIN_REFINE_FLAGS_REQUIRE_RATING |
GS_PLUGIN_REFINE_FLAGS_REQUIRE_ORIGIN_HOSTNAME |
diff --git a/src/gs-extras-page.c b/src/gs-extras-page.c
index c514e4d..4d0d0ca 100644
--- a/src/gs-extras-page.c
+++ b/src/gs-extras-page.c
@@ -691,7 +691,7 @@ gs_extras_page_load (GsExtrasPage *self, GPtrArray *array_search_data)
g_autoptr(GsPluginJob) plugin_job = NULL;
plugin_job = gs_plugin_job_newv (GS_PLUGIN_ACTION_SEARCH_FILES,
"search", search_data->search_filename,
- "failure-flags", GS_PLUGIN_FAILURE_FLAGS_USE_EVENTS,
+ "failure-flags", GS_PLUGIN_FAILURE_FLAGS_NONE,
"refine-flags", GS_PLUGIN_REFINE_FLAGS_REQUIRE_ICON |
GS_PLUGIN_REFINE_FLAGS_REQUIRE_RATING |
GS_PLUGIN_REFINE_FLAGS_ALLOW_PACKAGES,
@@ -708,7 +708,7 @@ gs_extras_page_load (GsExtrasPage *self, GPtrArray *array_search_data)
file = g_file_new_for_path (search_data->package_filename);
plugin_job = gs_plugin_job_newv (GS_PLUGIN_ACTION_FILE_TO_APP,
"file", file,
- "failure-flags", GS_PLUGIN_FAILURE_FLAGS_USE_EVENTS,
+ "failure-flags", GS_PLUGIN_FAILURE_FLAGS_NONE,
"refine-flags", GS_PLUGIN_REFINE_FLAGS_REQUIRE_ICON |
GS_PLUGIN_REFINE_FLAGS_REQUIRE_RATING |
GS_PLUGIN_REFINE_FLAGS_ALLOW_PACKAGES,
@@ -723,7 +723,7 @@ gs_extras_page_load (GsExtrasPage *self, GPtrArray *array_search_data)
g_debug ("searching what provides: '%s'", search_data->search);
plugin_job = gs_plugin_job_newv (GS_PLUGIN_ACTION_SEARCH_PROVIDES,
"search", search_data->search,
- "failure-flags", GS_PLUGIN_FAILURE_FLAGS_USE_EVENTS,
+ "failure-flags", GS_PLUGIN_FAILURE_FLAGS_NONE,
"refine-flags", GS_PLUGIN_REFINE_FLAGS_REQUIRE_ICON |
GS_PLUGIN_REFINE_FLAGS_REQUIRE_VERSION |
GS_PLUGIN_REFINE_FLAGS_REQUIRE_PROVENANCE |
diff --git a/src/gs-installed-page.c b/src/gs-installed-page.c
index 1c54be7..34f2339 100644
--- a/src/gs-installed-page.c
+++ b/src/gs-installed-page.c
@@ -279,7 +279,7 @@ gs_installed_page_load (GsInstalledPage *self)
/* get installed apps */
plugin_job = gs_plugin_job_newv (GS_PLUGIN_ACTION_GET_INSTALLED,
- "failure-flags", GS_PLUGIN_FAILURE_FLAGS_USE_EVENTS,
+ "failure-flags", GS_PLUGIN_FAILURE_FLAGS_NONE,
"refine-flags", flags,
NULL);
gs_plugin_loader_job_process_async (self->plugin_loader,
diff --git a/src/gs-loading-page.c b/src/gs-loading-page.c
index 8bb3582..4bac8bd 100644
--- a/src/gs-loading-page.c
+++ b/src/gs-loading-page.c
@@ -133,7 +133,7 @@ gs_loading_page_load (GsLoadingPage *self)
* spin up the plugins enough as to prime caches */
plugin_job = gs_plugin_job_newv (GS_PLUGIN_ACTION_REFRESH,
"age", (guint64) G_MAXUINT,
- "failure-flags", GS_PLUGIN_FAILURE_FLAGS_USE_EVENTS,
+ "failure-flags", GS_PLUGIN_FAILURE_FLAGS_NONE,
"refresh-flags", GS_PLUGIN_REFRESH_FLAGS_METADATA,
NULL);
gs_plugin_loader_job_process_async (priv->plugin_loader, plugin_job,
diff --git a/src/gs-moderate-page.c b/src/gs-moderate-page.c
index b03ceb2..c264e29 100644
--- a/src/gs-moderate-page.c
+++ b/src/gs-moderate-page.c
@@ -221,7 +221,7 @@ gs_moderate_page_load (GsModeratePage *self)
/* get unvoted reviews as apps */
plugin_job = gs_plugin_job_newv (GS_PLUGIN_ACTION_GET_UNVOTED_REVIEWS,
- "failure-flags", GS_PLUGIN_FAILURE_FLAGS_USE_EVENTS,
+ "failure-flags", GS_PLUGIN_FAILURE_FLAGS_NONE,
"refine-flags", GS_PLUGIN_REFINE_FLAGS_REQUIRE_ICON |
GS_PLUGIN_REFINE_FLAGS_REQUIRE_SETUP_ACTION |
GS_PLUGIN_REFINE_FLAGS_REQUIRE_VERSION |
diff --git a/src/gs-overview-page.c b/src/gs-overview-page.c
index 385c29e..7a88111 100644
--- a/src/gs-overview-page.c
+++ b/src/gs-overview-page.c
@@ -549,7 +549,7 @@ gs_overview_page_load (GsOverviewPage *self)
priv->loading_featured = TRUE;
plugin_job = gs_plugin_job_newv (GS_PLUGIN_ACTION_GET_FEATURED,
"max-results", 5,
- "failure-flags", GS_PLUGIN_FAILURE_FLAGS_USE_EVENTS,
+ "failure-flags", GS_PLUGIN_FAILURE_FLAGS_NONE,
"refine-flags", GS_PLUGIN_REFINE_FLAGS_REQUIRE_ICON,
NULL);
gs_plugin_loader_job_process_async (priv->plugin_loader,
@@ -566,7 +566,7 @@ gs_overview_page_load (GsOverviewPage *self)
priv->loading_popular = TRUE;
plugin_job = gs_plugin_job_newv (GS_PLUGIN_ACTION_GET_POPULAR,
"max-results", 20,
- "failure-flags", GS_PLUGIN_FAILURE_FLAGS_USE_EVENTS,
+ "failure-flags", GS_PLUGIN_FAILURE_FLAGS_NONE,
"refine-flags", GS_PLUGIN_REFINE_FLAGS_REQUIRE_RATING |
GS_PLUGIN_REFINE_FLAGS_REQUIRE_ICON,
NULL);
@@ -585,7 +585,7 @@ gs_overview_page_load (GsOverviewPage *self)
plugin_job = gs_plugin_job_newv (GS_PLUGIN_ACTION_GET_RECENT,
"age", (guint64) (60 * 60 * 24 * 60),
"max-results", 20,
- "failure-flags", GS_PLUGIN_FAILURE_FLAGS_USE_EVENTS,
+ "failure-flags", GS_PLUGIN_FAILURE_FLAGS_NONE,
"refine-flags", GS_PLUGIN_REFINE_FLAGS_REQUIRE_RATING |
GS_PLUGIN_REFINE_FLAGS_REQUIRE_ICON,
NULL);
@@ -626,7 +626,7 @@ gs_overview_page_load (GsOverviewPage *self)
plugin_job = gs_plugin_job_newv (GS_PLUGIN_ACTION_GET_CATEGORY_APPS,
"max-results", 20,
"category", featured_category,
- "failure-flags", GS_PLUGIN_FAILURE_FLAGS_USE_EVENTS,
+ "failure-flags", GS_PLUGIN_FAILURE_FLAGS_NONE,
"refine-flags",
GS_PLUGIN_REFINE_FLAGS_REQUIRE_RATING |
GS_PLUGIN_REFINE_FLAGS_REQUIRE_ICON,
NULL);
@@ -644,7 +644,7 @@ gs_overview_page_load (GsOverviewPage *self)
g_autoptr(GsPluginJob) plugin_job = NULL;
priv->loading_categories = TRUE;
plugin_job = gs_plugin_job_newv (GS_PLUGIN_ACTION_GET_CATEGORIES,
- "failure-flags", GS_PLUGIN_FAILURE_FLAGS_USE_EVENTS,
+ "failure-flags", GS_PLUGIN_FAILURE_FLAGS_NONE,
NULL);
gs_plugin_loader_job_get_categories_async (priv->plugin_loader, plugin_job,
priv->cancellable,
@@ -791,7 +791,7 @@ gs_overview_page_rescan_proprietary_sources (GsOverviewPage *self)
g_autoptr(GsPluginJob) plugin_job = NULL;
plugin_job = gs_plugin_job_newv (GS_PLUGIN_ACTION_GET_SOURCES,
- "failure-flags", GS_PLUGIN_FAILURE_FLAGS_USE_EVENTS,
+ "failure-flags", GS_PLUGIN_FAILURE_FLAGS_NONE,
"refine-flags", GS_PLUGIN_REFINE_FLAGS_REQUIRE_SETUP_ACTION,
NULL);
gs_plugin_loader_job_process_async (priv->plugin_loader,
diff --git a/src/gs-search-page.c b/src/gs-search-page.c
index c93e70a..0ed33a6 100644
--- a/src/gs-search-page.c
+++ b/src/gs-search-page.c
@@ -268,7 +268,7 @@ gs_search_page_load (GsSearchPage *self)
"search", self->value,
"max-results", self->max_results,
"timeout", 10,
- "failure-flags", GS_PLUGIN_FAILURE_FLAGS_USE_EVENTS,
+ "failure-flags", GS_PLUGIN_FAILURE_FLAGS_NONE,
"refine-flags", GS_PLUGIN_REFINE_FLAGS_REQUIRE_ICON |
GS_PLUGIN_REFINE_FLAGS_REQUIRE_VERSION |
GS_PLUGIN_REFINE_FLAGS_REQUIRE_PROVENANCE |
diff --git a/src/gs-updates-page.c b/src/gs-updates-page.c
index 1c1537a..71a5e29 100644
--- a/src/gs-updates-page.c
+++ b/src/gs-updates-page.c
@@ -1155,7 +1155,7 @@ gs_updates_page_load (GsUpdatesPage *self)
self->action_cnt++;
plugin_job = gs_plugin_job_newv (GS_PLUGIN_ACTION_GET_UPDATES,
"refine-flags", refine_flags,
- "failure-flags", GS_PLUGIN_FAILURE_FLAGS_USE_EVENTS,
+ "failure-flags", GS_PLUGIN_FAILURE_FLAGS_NONE,
NULL);
gs_plugin_loader_job_process_async (self->plugin_loader, plugin_job,
self->cancellable,
@@ -1180,7 +1180,7 @@ gs_updates_page_load (GsUpdatesPage *self)
g_object_unref (plugin_job);
plugin_job = gs_plugin_job_newv (GS_PLUGIN_ACTION_GET_DISTRO_UPDATES,
"refine-flags", refine_flags,
- "failure-flags", GS_PLUGIN_FAILURE_FLAGS_USE_EVENTS,
+ "failure-flags", GS_PLUGIN_FAILURE_FLAGS_NONE,
NULL);
gs_plugin_loader_job_process_async (self->plugin_loader,
plugin_job,
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]
