[gnome-photos] base-item: Unbreak reverting directly from OVERVIEW without PREVIEW



commit 7b47708d8f6fa968748f90e4a2e0e811db328730
Author: Debarshi Ray <debarshir gnome org>
Date:   Sat Sep 23 00:12:34 2017 +0200

    base-item: Unbreak reverting directly from OVERVIEW without PREVIEW
    
    Commit 8047f788f51cc551 decoupled the loading of the Pipeline from the
    rest of the BaseItem. The presence of a pipeline doesn't imply the
    existence of a buffer source, edit graph, etc..
    
    Therefore, discarding all edits from the overview, without loading the
    BaseItem, would lead to:
      CRITICAL **: photos_base_item_pipeline_save_async: assertion
        'priv->edit_graph != NULL' failed
    
    This prevented the thumbnail from getting updated and the revert
    wouldn't be persistent.
    
    Since saving a Pipeline doesn't even require a fully loaded BaseItem,
    it is enough to just remove this anachronistic and overzealous
    assertion.
    
    Fallout from 8047f788f51cc551e57b012372455154eb57f739
    
    https://bugzilla.gnome.org/show_bug.cgi?id=788715

 src/photos-base-item.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
---
diff --git a/src/photos-base-item.c b/src/photos-base-item.c
index b4bb313..3cd628a 100644
--- a/src/photos-base-item.c
+++ b/src/photos-base-item.c
@@ -4126,7 +4126,6 @@ photos_base_item_pipeline_save_async (PhotosBaseItem *self,
   priv = photos_base_item_get_instance_private (self);
 
   g_return_if_fail (!priv->collection);
-  g_return_if_fail (priv->edit_graph != NULL);
 
   pipeline = PHOTOS_PIPELINE (egg_task_cache_peek (pipeline_cache, self));
   g_return_if_fail (pipeline != NULL);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]