[gnome-boxes/gnome-3-24] wizard: Always use media-optical when downloading, not some bogus logo



commit 1de5059364445dd307a071c64509e7186ddb9c32
Author: Debarshi Ray <debarshir gnome org>
Date:   Mon Sep 11 18:18:45 2017 +0200

    wizard: Always use media-optical when downloading, not some bogus logo
    
    If the user temporarily selected any InstallerMedia, either from the
    file chooser or the list of local images, before deciding to download
    one from a URI, the logo wouldn't be reset. So, if a Fedora URI was
    preceded by selecting an Ubuntu image, then it would continue to show
    the Ubuntu logo while downloading Fedora.
    
    Since the "prepare" method is invoked twice for URIs requiring a
    download - once before initiating the download and once after, it is
    better to reset the icon even earlier.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=777133

 src/wizard.vala |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
---
diff --git a/src/wizard.vala b/src/wizard.vala
index 16879ad..c4cacb2 100644
--- a/src/wizard.vala
+++ b/src/wizard.vala
@@ -83,6 +83,7 @@ private class Boxes.Wizard: Gtk.Stack, Boxes.UI {
                     break;
 
                 case WizardPage.PREPARATION:
+                    installer_image.set_from_icon_name ("media-optical", 0); // Reset
                     if (!prepare (create_preparation_progress ()))
                         return;
                     break;
@@ -405,8 +406,6 @@ private class Boxes.Wizard: Gtk.Stack, Boxes.UI {
             return true;
         }
 
-        installer_image.set_from_icon_name ("media-optical", 0); // Reset
-
         if (this.wizard_source.install_media != null) {
             prep_media_label.label = _("Unknown installer media");
             prep_status_label.label = _("Analyzing…");


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]