[tracker] tests: Check return values for g_chmod/stat/remove calls

[Carlos Garnacho <carlosg src gnome org>]

commit 7fda0a271d086805c161444ded5173781f58328f
Author: Carlos Garnacho <carlosg gnome org>
Date:   Sat Sep 30 22:36:37 2017 +0200

    tests: Check return values for g_chmod/stat/remove calls
    
    Makes sense testing for those. Spotted by Coverity (CIDS: 1188421,
    1188422, 1188423, 1188430, 1188431, 1188432, 1188433, 1188434, 1188435,
    1298206, 1298207, 1298208, 1298209)

 tests/libtracker-common/tracker-file-utils-test.c  |   12 ++++++------
 tests/libtracker-data/tracker-backup-test.c        |    2 +-
 .../libtracker-data/tracker-ontology-change-test.c |    2 +-
 tests/libtracker-data/tracker-ontology-test.c      |    2 +-
 tests/libtracker-data/tracker-sparql-blank-test.c  |    2 +-
 tests/libtracker-data/tracker-sparql-test.c        |    2 +-
 tests/tracker-steroids/tracker-test.c              |    4 ++--
 7 files changed, 13 insertions(+), 13 deletions(-)
---
diff --git a/tests/libtracker-common/tracker-file-utils-test.c 
b/tests/libtracker-common/tracker-file-utils-test.c
index 1575c40..d1ddf30 100644
--- a/tests/libtracker-common/tracker-file-utils-test.c
+++ b/tests/libtracker-common/tracker-file-utils-test.c
@@ -47,7 +47,7 @@ static void
 remove_file (const gchar *filename)
 {
         g_assert (g_file_test (filename, G_FILE_TEST_EXISTS));
-        g_remove (filename);
+        g_assert_cmpint (g_remove (filename), ==, 0);
 }
 
 static GSList *
@@ -296,7 +296,7 @@ test_file_utils_get_size ()
         size = tracker_file_get_size (TEST_FILENAME);
         g_assert_cmpint (size, >, 0);
 
-        stat (TEST_FILENAME, &st);
+        g_assert_cmpint (stat (TEST_FILENAME, &st), ==, 0);
         g_assert_cmpint (size, ==, st.st_size);
 
         /* File doesn't exist */
@@ -314,7 +314,7 @@ test_file_utils_get_mtime ()
         mtime = tracker_file_get_mtime (TEST_FILENAME);
         g_assert_cmpint (mtime, >, 0);
 
-        stat (TEST_FILENAME, &st);
+        g_assert_cmpint (stat (TEST_FILENAME, &st), ==, 0);
         // This comparison could lead a problem in 32/64 bits?
         g_assert_cmpint (mtime, ==, st.st_mtime);
 
@@ -373,7 +373,7 @@ test_file_exists_and_writable ()
         const gchar *path = "./test-dir-remove-afterwards";
 
         if (g_file_test (path, G_FILE_TEST_EXISTS)) {
-                g_remove (path);
+               g_assert_cmpint (g_remove (path), ==, 0);
         }
 
         /* This should create the directory with write access*/
@@ -383,7 +383,7 @@ test_file_exists_and_writable ()
         /* This time exists and has write access */
         g_assert (tracker_path_has_write_access_or_was_created (path));
 
-        chmod (path, S_IRUSR & S_IRGRP);
+        g_assert_cmpint (chmod (path, S_IRUSR & S_IRGRP), ==, 0);
 
         /* Exists but is not writable */
         g_assert (!tracker_path_has_write_access_or_was_created (path));
@@ -391,7 +391,7 @@ test_file_exists_and_writable ()
         /* Doesn't exist and cannot be created */
         g_assert (!tracker_path_has_write_access_or_was_created ("/var/log/tracker-test"));
 
-        g_remove (path);
+        g_assert_cmpint (g_remove (path), ==, 0);
 }
 
 static void
diff --git a/tests/libtracker-data/tracker-backup-test.c b/tests/libtracker-data/tracker-backup-test.c
index 1714f58..67522e6 100644
--- a/tests/libtracker-data/tracker-backup-test.c
+++ b/tests/libtracker-data/tracker-backup-test.c
@@ -149,7 +149,7 @@ test_backup_and_restore_helper (const gchar *db_location,
        check_content_in_db (manager, 3, 1);
 
        backup_location = g_build_filename (db_location, "backup", NULL);
-       g_mkdir (backup_location, 0777);
+       g_assert_cmpint (g_mkdir (backup_location, 0777), ==, 0);
        backup_filename = g_build_filename (backup_location, "tracker.dump", NULL);
        backup_file = g_file_new_for_path (backup_filename);
        g_free (backup_filename);
diff --git a/tests/libtracker-data/tracker-ontology-change-test.c 
b/tests/libtracker-data/tracker-ontology-change-test.c
index c7fc235..325c63b 100644
--- a/tests/libtracker-data/tracker-ontology-change-test.c
+++ b/tests/libtracker-data/tracker-ontology-change-test.c
@@ -229,7 +229,7 @@ test_ontology_change (void)
                g_file_copy (file1, file2, G_FILE_COPY_OVERWRITE, NULL, NULL, NULL, &error);
 
                g_assert_no_error (error);
-               g_chmod (ontology_file, 0666);
+               g_assert_cmpint (g_chmod (ontology_file, 0666), ==, 0);
 
                manager = tracker_data_manager_new (0, data_location, data_location, test_schemas,
                                                    FALSE, FALSE, 100, 100);
diff --git a/tests/libtracker-data/tracker-ontology-test.c b/tests/libtracker-data/tracker-ontology-test.c
index 4b17e67..53ceaac 100644
--- a/tests/libtracker-data/tracker-ontology-test.c
+++ b/tests/libtracker-data/tracker-ontology-test.c
@@ -342,7 +342,7 @@ main (int argc, char **argv)
        /* run tests */
        result = g_test_run ();
 
-       g_remove (tests_data_dir);
+       g_assert_cmpint (g_remove (tests_data_dir), ==, 0);
        g_free (tests_data_dir);
 
        return result;
diff --git a/tests/libtracker-data/tracker-sparql-blank-test.c 
b/tests/libtracker-data/tracker-sparql-blank-test.c
index 73adc28..2c22d4f 100644
--- a/tests/libtracker-data/tracker-sparql-blank-test.c
+++ b/tests/libtracker-data/tracker-sparql-blank-test.c
@@ -172,7 +172,7 @@ main (int argc, char **argv)
        /* run tests */
        result = g_test_run ();
 
-       g_remove (tests_data_dir);
+       g_assert_cmpint (g_remove (tests_data_dir), ==, 0);
        g_free (tests_data_dir);
 
        return result;
diff --git a/tests/libtracker-data/tracker-sparql-test.c b/tests/libtracker-data/tracker-sparql-test.c
index 3b16cca..de4e3bc 100644
--- a/tests/libtracker-data/tracker-sparql-test.c
+++ b/tests/libtracker-data/tracker-sparql-test.c
@@ -423,7 +423,7 @@ main (int argc, char **argv)
        /* run tests */
        result = g_test_run ();
 
-       g_remove (tests_data_dir);
+       g_assert_cmpint (g_remove (tests_data_dir), ==, 0);
        g_free (tests_data_dir);
 
        return result;
diff --git a/tests/tracker-steroids/tracker-test.c b/tests/tracker-steroids/tracker-test.c
index e9782dc..19bee6d 100644
--- a/tests/tracker-steroids/tracker-test.c
+++ b/tests/tracker-steroids/tracker-test.c
@@ -226,7 +226,7 @@ test_tracker_sparql_query_iterate_empty_subprocess ()
 
        cursor = tracker_sparql_connection_query (connection, query, NULL, &error);
 
-       tracker_sparql_cursor_next (cursor, NULL, NULL);
+       g_assert (tracker_sparql_cursor_next (cursor, NULL, NULL));
 
        /* Testing we fail with this error:
         *
@@ -273,7 +273,7 @@ test_tracker_sparql_query_iterate_sigpipe ()
        g_assert (cursor);
        g_assert_no_error (error);
 
-       tracker_sparql_cursor_next (cursor, NULL, NULL);
+       g_assert (tracker_sparql_cursor_next (cursor, NULL, NULL));
 
        g_object_unref (cursor);
 }