[vala/wip/valadate: 95/101] Some clean up
- From: Rico Tzschichholz <ricotz src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [vala/wip/valadate: 95/101] Some clean up
- Date: Sat, 7 Oct 2017 10:57:58 +0000 (UTC)
commit bb993d0d02cc2e76347936ef9d7440be873a272c
Author: Rico Tzschichholz <ricotz ubuntu com>
Date: Mon May 1 11:01:10 2017 +0200
Some clean up
tests/.gitignore | 2 --
valadate/assembly.vala | 21 +++++++++------------
valadate/testassembly.vala | 6 +++---
3 files changed, 12 insertions(+), 17 deletions(-)
---
diff --git a/tests/.gitignore b/tests/.gitignore
index ba1d9d7..53d7587 100644
--- a/tests/.gitignore
+++ b/tests/.gitignore
@@ -4,5 +4,3 @@
*.trs
valadatetests
valactests-*
-README
-gir/bug767718.test
diff --git a/valadate/assembly.vala b/valadate/assembly.vala
index 26159a0..2f91251 100644
--- a/valadate/assembly.vala
+++ b/valadate/assembly.vala
@@ -26,20 +26,17 @@ public abstract class Valadate.Assembly {
private static void init_launcher () {
if (launcher == null) {
- launcher = new SubprocessLauncher (
- GLib.SubprocessFlags.STDIN_PIPE |
- GLib.SubprocessFlags.STDOUT_PIPE |
- GLib.SubprocessFlags.STDERR_PIPE);
- launcher.setenv ("G_MESSAGES_DEBUG","all",true);
- launcher.setenv ("G_DEBUG","fatal-criticals fatal-warnings gc-friendly",true);
- launcher.setenv ("G_SLICE","always-malloc debug-blocks",true);
+ launcher = new SubprocessLauncher (SubprocessFlags.STDIN_PIPE |
SubprocessFlags.STDOUT_PIPE | SubprocessFlags.STDERR_PIPE);
+ launcher.setenv ("G_MESSAGES_DEBUG", "all", true);
+ launcher.setenv ("G_DEBUG", "fatal-criticals fatal-warnings gc-friendly", true);
+ launcher.setenv ("G_SLICE", "always-malloc debug-blocks", true);
}
}
- public File binary { get; set; }
- public InputStream stderr { get; set; }
- public OutputStream stdin { get; set; }
- public InputStream stdout { get; set; }
+ public File binary { get; private set; }
+ public InputStream stderr { get; private set; }
+ public OutputStream stdin { get; private set; }
+ public InputStream stdout { get; private set; }
private Subprocess process;
@@ -54,7 +51,7 @@ public abstract class Valadate.Assembly {
public abstract Assembly clone () throws Error;
- public virtual Assembly run (string? command = null, Cancellable? cancellable = null) throws Error {
+ public virtual unowned Assembly run (string? command = null, Cancellable? cancellable = null) throws
Error {
string[] args;
Shell.parse_argv ("%s %s".printf (binary.get_path (), command ?? ""), out args);
process = launcher.spawnv (args);
diff --git a/valadate/testassembly.vala b/valadate/testassembly.vala
index 718f69a..7985a80 100644
--- a/valadate/testassembly.vala
+++ b/valadate/testassembly.vala
@@ -22,10 +22,10 @@
public class Valadate.TestAssembly : TestModule {
- public File srcdir {get;set;}
- public File builddir {get;set;}
+ public File srcdir { get; private set; }
+ public File builddir { get; private set; }
- public TestOptions options {get;set;}
+ public TestOptions options { get; private set; }
public TestAssembly (string[] args) throws Error {
base (File.new_for_path (args[0]));
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]