[gimp/wip/animation: 341/373] plug-ins: fix update when changing camera position.
- From: Jehan Pagès <jehanp src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gimp/wip/animation: 341/373] plug-ins: fix update when changing camera position.
- Date: Sat, 7 Oct 2017 02:23:23 +0000 (UTC)
commit 1da934fff1639a5bb49ec0594f47c098c8c60692
Author: Jehan <jehan girinstud io>
Date: Mon Jun 26 00:44:20 2017 +0200
plug-ins: fix update when changing camera position.
Also do not limit camera position to the animation (nor the image) size.
Finally I don't show the unit menu. Actually I'd like to be able to show
the percentage unit, but not all the physical ones. I will have to have
a look at this later.
.../widgets/animation-keyframe-view.c | 11 +++++++----
1 files changed, 7 insertions(+), 4 deletions(-)
---
diff --git a/plug-ins/animation-play/widgets/animation-keyframe-view.c
b/plug-ins/animation-play/widgets/animation-keyframe-view.c
index 810f09c..4424678 100644
--- a/plug-ins/animation-play/widgets/animation-keyframe-view.c
+++ b/plug-ins/animation-play/widgets/animation-keyframe-view.c
@@ -123,9 +123,11 @@ animation_keyframe_view_show (AnimationKeyFrameView *view,
animation_get_size (ANIMATION (animation), &width, &height);
gimp_size_entry_set_refval_boundaries (GIMP_SIZE_ENTRY (view->priv->offset_entry),
- 0, (gdouble) -width, (gdouble) width);
+ 0, (gdouble) -GIMP_MAX_IMAGE_SIZE,
+ (gdouble) GIMP_MAX_IMAGE_SIZE);
gimp_size_entry_set_refval_boundaries (GIMP_SIZE_ENTRY (view->priv->offset_entry),
- 1, (gdouble) -height, (gdouble) height);
+ 1, (gdouble) -GIMP_MAX_IMAGE_SIZE,
+ (gdouble) GIMP_MAX_IMAGE_SIZE);
gimp_size_entry_set_size (GIMP_SIZE_ENTRY (view->priv->offset_entry),
0, 0.0, (gdouble) width);
gimp_size_entry_set_size (GIMP_SIZE_ENTRY (view->priv->offset_entry),
@@ -189,6 +191,7 @@ animation_keyframe_view_constructed (GObject *object)
gimp_size_entry_attach_label (GIMP_SIZE_ENTRY (view->priv->offset_entry),
_("Vertical offset:"), 0, 2, 0.0);
gimp_size_entry_set_pixel_digits (GIMP_SIZE_ENTRY (view->priv->offset_entry), 0);
+ gimp_size_entry_show_unit_menu (GIMP_SIZE_ENTRY (view->priv->offset_entry), FALSE);
gtk_box_pack_start (GTK_BOX (page), view->priv->offset_entry, FALSE, FALSE, 0);
gtk_widget_show (view->priv->offset_entry);
@@ -206,7 +209,7 @@ on_offset_entry_changed (GimpSizeEntry *entry,
y_offset = gimp_size_entry_get_refval (GIMP_SIZE_ENTRY (view->priv->offset_entry), 1);
animation_camera_set_keyframe (view->priv->camera,
view->priv->position,
- x_offset, y_offset);
+ (gint) x_offset, (gint) y_offset);
}
static void
@@ -224,7 +227,7 @@ on_offsets_changed (AnimationCamera *camera,
g_signal_handlers_block_by_func (view->priv->offset_entry,
G_CALLBACK (on_offset_entry_changed),
view);
- animation_camera_get (camera, position, &x_offset, &y_offset);
+ animation_camera_get (camera, view->priv->position, &x_offset, &y_offset);
gimp_size_entry_set_value (GIMP_SIZE_ENTRY (view->priv->offset_entry),
0, (gdouble) x_offset);
gimp_size_entry_set_value (GIMP_SIZE_ENTRY (view->priv->offset_entry),
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]