[gtk+] TreeViewCol: Fix SEGV on remove/add, + memory leak
- From: Daniel Boles <dboles src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk+] TreeViewCol: Fix SEGV on remove/add, + memory leak
- Date: Fri, 6 Oct 2017 23:47:40 +0000 (UTC)
commit 497e877755f1fa165cdc8d14bf6b020d89c8ad2e
Author: Daniel Boles <dboles src gnome org>
Date: Fri Oct 6 20:24:49 2017 +0100
TreeViewCol: Fix SEGV on remove/add, + memory leak
Nulling priv->button in _unset_tree_view() is asymmetrical: we create
it via init(), not _set_tree_view(), so we shouldn’t null in the latter.
Worse, doing so manifests in criticals + a SEGV easily with basic use of
testtreecolumns, removing the TVC from a TV then trying to add it to one
Finally, the wrong null-out meant dispose() failed to unref the button,
so it leaked.
https://bugzilla.gnome.org/show_bug.cgi?id=728452
https://bugzilla.gnome.org/show_bug.cgi?id=788614
gtk/gtktreeviewcolumn.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
---
diff --git a/gtk/gtktreeviewcolumn.c b/gtk/gtktreeviewcolumn.c
index 9dd368a..34a6032 100644
--- a/gtk/gtktreeviewcolumn.c
+++ b/gtk/gtktreeviewcolumn.c
@@ -1350,7 +1350,6 @@ _gtk_tree_view_column_unset_tree_view (GtkTreeViewColumn *column)
}
priv->tree_view = NULL;
- priv->button = NULL;
}
gboolean
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]