[glib] Type accuracy for result of strlen() in string utilities
- From: Philip Withnall <pwithnall src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glib] Type accuracy for result of strlen() in string utilities
- Date: Fri, 6 Oct 2017 11:32:36 +0000 (UTC)
commit 7895706c828c864640083d17e255bf4eafe5d692
Author: Andrew Borodin <aborodin vmail ru>
Date: Wed Sep 29 21:45:53 2010 +0400
Type accuracy for result of strlen() in string utilities
https://bugzilla.gnome.org/show_bug.cgi?id=630983
glib/gstrfuncs.c | 20 ++++++++++----------
1 files changed, 10 insertions(+), 10 deletions(-)
---
diff --git a/glib/gstrfuncs.c b/glib/gstrfuncs.c
index ae052af..093c625 100644
--- a/glib/gstrfuncs.c
+++ b/glib/gstrfuncs.c
@@ -703,7 +703,7 @@ g_ascii_strtod (const gchar *nptr,
struct lconv *locale_data;
#endif
const char *decimal_point;
- int decimal_point_len;
+ gsize decimal_point_len;
const char *p, *decimal_point_pos;
const char *end = NULL; /* Silence gcc */
int strtod_errno;
@@ -920,7 +920,7 @@ g_ascii_formatd (gchar *buffer,
struct lconv *locale_data;
#endif
const char *decimal_point;
- int decimal_point_len;
+ gsize decimal_point_len;
gchar *p;
int rest_len;
gchar format_char;
@@ -980,8 +980,8 @@ g_ascii_formatd (gchar *buffer,
p++;
if (decimal_point_len > 1)
{
- rest_len = strlen (p + (decimal_point_len-1));
- memmove (p, p + (decimal_point_len-1), rest_len);
+ rest_len = strlen (p + (decimal_point_len - 1));
+ memmove (p, p + (decimal_point_len - 1), rest_len);
p[rest_len] = 0;
}
}
@@ -1522,9 +1522,9 @@ g_ascii_strdown (const gchar *str,
g_return_val_if_fail (str != NULL, NULL);
if (len < 0)
- len = strlen (str);
+ len = (gssize) strlen (str);
- result = g_strndup (str, len);
+ result = g_strndup (str, (gsize) len);
for (s = result; *s; s++)
*s = g_ascii_tolower (*s);
@@ -1552,9 +1552,9 @@ g_ascii_strup (const gchar *str,
g_return_val_if_fail (str != NULL, NULL);
if (len < 0)
- len = strlen (str);
+ len = (gssize) strlen (str);
- result = g_strndup (str, len);
+ result = g_strndup (str, (gsize) len);
for (s = result; *s; s++)
*s = g_ascii_toupper (*s);
@@ -2841,8 +2841,8 @@ gboolean
g_str_has_suffix (const gchar *str,
const gchar *suffix)
{
- int str_len;
- int suffix_len;
+ gsize str_len;
+ gsize suffix_len;
g_return_val_if_fail (str != NULL, FALSE);
g_return_val_if_fail (suffix != NULL, FALSE);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]